Re: [PATCH v4] libxl: add option for discard support to xl disk configuration

[Olaf Hering <olaf@aepfle.de>]

On Mon, May 05, Konrad Rzeszutek Wilk wrote:

> > +++ b/tools/libxl/libxlu_disk_l.l
> > @@ -174,6 +174,10 @@ backendtype=[^,]*,? { STRIP(','); setbackendtype(DPC,FROMEQUALS); }
> >  vdev=[^,]*,?	{ STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); }
> >  script=[^,]*,?	{ STRIP(','); SAVESTRING("script", script, FROMEQUALS); }
> >  direct-io-safe,? { DPC->disk->direct_io_safe = 1; }
> > +discard=on,?	{ libxl_defbool_set(&DPC->disk->discard_enable, true); }
> > +discard=1,?	{ libxl_defbool_set(&DPC->disk->discard_enable, true); }
> > +discard=off,?	{ libxl_defbool_set(&DPC->disk->discard_enable, false); }
> > +discard=0,?	{ libxl_defbool_set(&DPC->disk->discard_enable, false); }
> 
> I think this automatically generated?

Yes, bison/flex should be rerun after applying this change.

> > + *      backend driver should ignore the property if the property is set but
> > + *      the backing storage does not support the feature.
> ? I think you want to say: "The backend driver should ignore the propery
> if the backing storage does not expose this functionality."

That would be ok as well, if your version is better english anyway.


Olaf