* [PATCH] libxl: fix DEFINE_DEVICES_ADD related typo in comment
@ 2014-05-06 15:16 Olaf Hering
2014-05-06 15:19 ` Olaf Hering
0 siblings, 1 reply; 3+ messages in thread
From: Olaf Hering @ 2014-05-06 15:16 UTC (permalink / raw)
To: xen-devel; +Cc: Olaf Hering, ian.jackson, ian.campbell, stefano.stabellini
The macro DEFINE_DEVICES_ADD is called with "disk", not "disks".
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
tools/libxl/libxl_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/libxl_device.c b/tools/libxl/libxl_device.c
index 856e147..e7eab54 100644
--- a/tools/libxl/libxl_device.c
+++ b/tools/libxl/libxl_device.c
@@ -521,7 +521,7 @@ void libxl__multidev_prepared(libxl__egc *egc,
* This macro is added to prevent repetition of code.
*
* The following functions are defined:
- * libxl__add_disks
+ * libxl__add_disk
* libxl__add_nics
* libxl__add_vtpms
*/
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libxl: fix DEFINE_DEVICES_ADD related typo in comment
2014-05-06 15:16 [PATCH] libxl: fix DEFINE_DEVICES_ADD related typo in comment Olaf Hering
@ 2014-05-06 15:19 ` Olaf Hering
2014-05-07 8:38 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Olaf Hering @ 2014-05-06 15:19 UTC (permalink / raw)
To: xen-devel; +Cc: ian.jackson, ian.campbell, stefano.stabellini
On Tue, May 06, Olaf Hering wrote:
> The macro DEFINE_DEVICES_ADD is called with "disk", not "disks".
... but the macro adds the trailing 's', so the comment is correct.
Please drop this patch.
Olaf
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libxl: fix DEFINE_DEVICES_ADD related typo in comment
2014-05-06 15:19 ` Olaf Hering
@ 2014-05-07 8:38 ` Ian Campbell
0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2014-05-07 8:38 UTC (permalink / raw)
To: Olaf Hering; +Cc: stefano.stabellini, ian.jackson, xen-devel
On Tue, 2014-05-06 at 17:19 +0200, Olaf Hering wrote:
> On Tue, May 06, Olaf Hering wrote:
>
> > The macro DEFINE_DEVICES_ADD is called with "disk", not "disks".
>
> ... but the macro adds the trailing 's', so the comment is correct.
> Please drop this patch.
Done!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-07 8:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-06 15:16 [PATCH] libxl: fix DEFINE_DEVICES_ADD related typo in comment Olaf Hering
2014-05-06 15:19 ` Olaf Hering
2014-05-07 8:38 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).