Re: [PATCH v4 09/15] autoconf: xen: force a refresh with autoconf

["Luis R. Rodriguez" <mcgrof@suse.com>]

On Wed, May 07, 2014 at 06:44:25PM +0200, Roger Pau Monné wrote:
> On 07/05/14 18:21, Ian Campbell wrote:
> > On Wed, 2014-05-07 at 18:12 +0200, Roger Pau Monné wrote:
> >> On 30/04/14 03:12, Luis R. Rodriguez wrote:
> >>> From: "Luis R. Rodriguez" <mcgrof@suse.com>
> >>>
> >>> With some new functionality introduced we can't keep around the old cache.
> >>>
> >>> Cc: Ian Campbell <ian.campbell@citrix.com>
> >>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> >>> Cc: Jan Beulich <jbeulich@suse.com>
> >>> Cc: Keir Fraser <keir@xen.org>
> >>> Cc: Tim Deegan <tim@xen.org>
> >>> Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
> >>> ---
> >>>  autogen.sh | 8 ++++----
> >>>  1 file changed, 4 insertions(+), 4 deletions(-)
> >>>
> >>> diff --git a/autogen.sh b/autogen.sh
> >>> index b5c9688..2be8360 100755
> >>> --- a/autogen.sh
> >>> +++ b/autogen.sh
> >>> @@ -1,12 +1,12 @@
> >>>  #!/bin/sh -e
> >>> -autoconf
> >>> +autoconf -f
> >>>  ( cd tools
> >>> -  autoconf
> >>> +  autoconf -f
> >>>    autoheader
> >>>  )
> >>>  ( cd stubdom
> >>> -  autoconf
> >>> +  autoconf -f
> >>>  )
> >>>  ( cd docs
> >>> -  autoconf
> >>> +  autoconf -f
> >>>  )
> >>
> >> Not that is that important, but why do you need to force the regen of
> >> all files? I expect autoconf should be able to detect which files need
> >> rebuilding.
> > 
> > I've observed it not doing so, when I thought it should, I never figured
> > out why and/or if I was mistaken though
> 
> I have not seen this myself, but if it's the case (and provided that the
> commit message is reworded to reflect this):
> 
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>

I spotted what I think is a bug on autoconf where I observed inconsistent
behaviour when you touch a file, sometimes it yielded the results you wanted,
sometimes it did not, in the end I got close to linking the issue to the cache
somehow, but before I dove myself deeper into autoconf I found a force prevents
this issue which let me conserve some of the remaining sanity I have left. I'll
follow up with upstream autoconf on this eventually but figured providing
all the glory details on this on the commit log was not worth it. I'll respin
and add all the glory details.

  Luis