Re: [PATCH v4 14/15] autoconf: xen: add systemd support into the build system

["Luis R. Rodriguez" <mcgrof@suse.com>]

On Wed, May 07, 2014 at 06:40:01PM +0200, Roger Pau Monné wrote:
> On 30/04/14 03:12, Luis R. Rodriguez wrote:
> > From: "Luis R. Rodriguez" <mcgrof@suse.com>
> > +dnl Once and if systemd is prevalent we can just use AX_ENABLE_SYSTEMD()
> > +AX_ALLOW_SYSTEMD()
> 
> Shouldn't systemd init scripts be installed by default if systemd is
> detect on the host?

That is up to whoever is building the stuff, if systemd is enabled then
both old init scripts and systemd scripts will be installed.

> Or are there cases of distros that install systemd but don't use it?

There are cases where a system can have libraries for systemd but not
have systemd.

> If I'm understanding this right, the user has to always pass
> --enable-systemd in order to get systemd init scripts installed.

For now I think this is a good option as we get systemd widely tested,
eventually I agree that this should be switched to AX_ENABLE_SYSTEMD()
which will then enable systemd if systemd libraries are detected. I'd
prefer we do this once we get all all this widely tested.

> >  AC_OUTPUT()
> >  
> > diff --git a/tools/hotplug/common/Makefile b/tools/hotplug/common/Makefile
> > index 4a63f40..45fd840 100644
> > --- a/tools/hotplug/common/Makefile
> > +++ b/tools/hotplug/common/Makefile
> > @@ -1,5 +1,6 @@
> >  XEN_ROOT = $(CURDIR)/../../..
> >  include $(XEN_ROOT)/tools/Rules.mk
> > +include $(XEN_ROOT)/config/Tools.mk
> 
> tools/Rules.mk already includes config/Tools.mk

Good catch, changed.

 Luis