Re: [PATCH v6] libxl: add option for discard support to xl disk configuration

[Olaf Hering <olaf@aepfle.de>]

On Mon, May 19, Ian Jackson wrote:

> Olaf Hering writes ("[PATCH v6] libxl: add option for discard support to xl disk configuration"):
> > Handle new boolean option discard/no-discard for disk configuration. It
> > is supposed to disable discard support if file based backing storage was
> > intentionally created non-sparse to avoid fragmentation of the file.
> > 
> > The option intended for the backend driver. A new boolean property
> > "discard-enable" is written to the backend node. An upcoming patch for
> > qemu will make use of this property. The kernel blkback driver may be
> > updated as well to disable discard for phy based backing storage.
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 
> (I made a tiny edit to the doc file as I committed, removing a
> spurious comma.)

The patch changes .l and .idl files. Did I place the comment
incorrectly, did you overlook the comment or should my patch contain
also the updates to generated files?

Perhaps the required steps for the commiter should be written down
somewhere, so that patch submissions for templates fits in your
workflow.


Olaf