From: Matt Fleming <matt@console-pimps.org>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: mjg59@srcf.ucam.org, jeremy@goop.org, linux-efi@vger.kernel.org,
ian.campbell@citrix.com, x86@kernel.org,
linux-kernel@vger.kernel.org, matt.fleming@intel.com,
tglx@linutronix.de, David Vrabel <david.vrabel@citrix.com>,
jbeulich@suse.com, hpa@zytor.com, xen-devel@lists.xenproject.org,
boris.ostrovsky@oracle.com, mingo@redhat.com,
stefano.stabellini@eu.citrix.com, eshelton@pobox.com
Subject: Re: [PATCH v4 1/5] efi: Introduce EFI_DIRECT flag
Date: Thu, 22 May 2014 08:26:01 +0100 [thread overview]
Message-ID: <20140522072601.GP4798@console-pimps.org> (raw)
In-Reply-To: <20140519210255.GC3529@olila.local.net-space.pl>
On Mon, 19 May, at 11:02:55PM, Daniel Kiper wrote:
>
> It is correct. As I said earlier: in case of !efi_enabled(EFI_DIRECT) some
> structures are created artificially and they live in virtual address space.
> So that is why they should not be mapped.
So, exploring Jan's idea, is it not possible to store the physical
address and have early_ioremap() just work? Even if they're mapping in
virtual address space they must have a corresponding physical address.
We really need to be keeping these kinds of special code paths to a
minimum. Unless absolutely necessary there should be just one way to do
things.
> I was going to have EFI_DIRECT close to EFI_BOOT which is quite generic
> and platform independent name like EFI_BOOT. However, I do not insist
> on having it in that place.
Right, please don't shuffle these bits.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-05-22 7:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1400272904-31121-1-git-send-email-daniel.kiper@oracle.com>
2014-05-16 20:41 ` [PATCH v4 1/5] efi: Introduce EFI_DIRECT flag Daniel Kiper
2014-05-16 20:41 ` [PATCH v4 2/5] xen: Define EFI related stuff Daniel Kiper
2014-05-16 20:41 ` [PATCH v4 3/5] xen: Put EFI machinery in place Daniel Kiper
2014-05-16 20:41 ` [PATCH v4 4/5] arch/x86: Replace plain strings with constants Daniel Kiper
2014-05-16 20:41 ` [PATCH v4 5/5] arch/x86: Remove redundant set_bit() call Daniel Kiper
[not found] ` <1400272904-31121-2-git-send-email-daniel.kiper@oracle.com>
2014-05-19 13:30 ` [PATCH v4 1/5] efi: Introduce EFI_DIRECT flag Jan Beulich
2014-05-19 15:58 ` David Vrabel
[not found] ` <537A23A50200007800013A7F@mail.emea.novell.com>
2014-05-19 20:46 ` Daniel Kiper
[not found] ` <20140519204657.GB3529@olila.local.net-space.pl>
2014-05-20 6:16 ` Jan Beulich
[not found] ` <537A2A28.4010903@citrix.com>
2014-05-19 21:02 ` Daniel Kiper
[not found] ` <20140519210255.GC3529@olila.local.net-space.pl>
2014-05-22 7:26 ` Matt Fleming [this message]
2014-05-19 15:53 ` [PATCH v4 0/5] xen: Add EFI support David Vrabel
[not found] ` <1400272904-31121-3-git-send-email-daniel.kiper@oracle.com>
2014-05-19 16:00 ` [PATCH v4 2/5] xen: Define EFI related stuff David Vrabel
[not found] ` <1400272904-31121-4-git-send-email-daniel.kiper@oracle.com>
2014-05-19 13:39 ` [PATCH v4 3/5] xen: Put EFI machinery in place Andrew Cooper
2014-05-19 13:43 ` Jan Beulich
[not found] ` <537A0974.40302@citrix.com>
2014-05-19 13:47 ` Jan Beulich
2014-05-20 9:47 ` David Vrabel
[not found] ` <537B2494.2080702@citrix.com>
2014-05-20 11:29 ` Daniel Kiper
[not found] ` <20140520112933.GF3529@olila.local.net-space.pl>
2014-05-20 11:58 ` Jan Beulich
2014-05-20 12:10 ` David Vrabel
[not found] ` <1400272904-31121-5-git-send-email-daniel.kiper@oracle.com>
2014-05-22 7:56 ` [PATCH v4 4/5] arch/x86: Replace plain strings with constants Matt Fleming
[not found] ` <1400272904-31121-6-git-send-email-daniel.kiper@oracle.com>
2014-05-22 7:59 ` [PATCH v4 5/5] arch/x86: Remove redundant set_bit() call Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140522072601.GP4798@console-pimps.org \
--to=matt@console-pimps.org \
--cc=boris.ostrovsky@oracle.com \
--cc=daniel.kiper@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=eshelton@pobox.com \
--cc=hpa@zytor.com \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=jeremy@goop.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=mjg59@srcf.ucam.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).