From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Hajnoczi Subject: Re: [PATCH v2 2/3] tap-bsd: implement a FreeBSD only version of tap_open Date: Tue, 27 May 2014 15:29:43 +0200 Message-ID: <20140527132943.GD31463@stefanha-thinkpad.redhat.com> References: <1400860669-21593-1-git-send-email-roger.pau@citrix.com> <1400860669-21593-3-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WpHRy-00078b-CA for xen-devel@lists.xenproject.org; Tue, 27 May 2014 13:29:54 +0000 Content-Disposition: inline In-Reply-To: <1400860669-21593-3-git-send-email-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau Monne Cc: xen-devel@lists.xenproject.org, Anthony Liguori , qemu-devel@nongnu.org, Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Fri, May 23, 2014 at 05:57:48PM +0200, Roger Pau Monne wrote: > The current behaviour of tap_open for BSD systems differ greatly from > it's Linux counterpart. Since FreeBSD supports interface renaming and > tap device cloning by opening /dev/tap, implement a FreeBSD specific > version of tap_open that behaves like it's Linux counterpart. > = > This is specially important for toolstacks that use Qemu (like Xen > libxl), in order to have a unified behaviour across suported > platforms. > = > Signed-off-by: Roger Pau Monn=E9 > Cc: xen-devel@lists.xenproject.org > Cc: Stefano Stabellini > Cc: Anthony Liguori > Cc: Stefan Hajnoczi > --- > net/tap-bsd.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++++++= +++++- > 1 files changed, 69 insertions(+), 1 deletions(-) Reviewed-by: Stefan Hajnoczi