From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH V5 27/32] libxl: libxl-json format and
 load/store configuration functions
Date: Mon, 2 Jun 2014 20:56:19 +0100
Message-ID: <20140602195619.GA19767@zion.uk.xensource.com>
References: <1400018054-26038-1-git-send-email-wei.liu2@citrix.com>
	<1400018054-26038-28-git-send-email-wei.liu2@citrix.com>
	<1400594636.6946.71.camel@kazak.uk.xensource.com>
	<20140601184157.GB25584@zion.uk.xensource.com>
	<1401725986.8841.17.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1401725986.8841.17.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: ian.jackson@eu.citrix.com, Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Mon, Jun 02, 2014 at 05:19:46PM +0100, Ian Campbell wrote:
[...]
> 
> But then you call libxl__realloc(gc,...). Won't that add the new pointer
> to the gc (and fail to remove the old one from it because it wasn't
> there)? Then you free it with free() and then GC_FREE will double free
> it.
> 

Oh, yes, you're right. I will fix this -- if this hunk is kept in my
future version. Thanks.

Wei.

> Ian.