xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Tim Deegan <tim@xen.org>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>,
	Jan Beulich <JBeulich@suse.com>
Subject: pvh dom0: memory leak from iomem map
Date: Tue, 3 Jun 2014 18:29:48 -0700	[thread overview]
Message-ID: <20140603182948.073180cf@mantra.us.oracle.com> (raw)

Hi Tim,

When building a dom0 pvh, we populate the p2m with 0..N pfns upfront. Then
in pvh_map_all_iomem, we walk the e820 and map all iomem 1:1. As such
any iomem range below N would cause those ram frames to be silently dropped. 
Since the holes could be pretty big, I am concenred this could result
in significant loss of frames. 

In my very early patches I had:

set_typed_p2m_entry():
...
    else if ( p2m_is_ram(ot) )
    {
         if ( is_pvh_domain(d) )                    <---
             free_domheap_page(mfn_to_page(omfn));  <---

         ASSERT(mfn_valid(omfn));
         set_gpfn_from_mfn(mfn_x(omfn), INVALID_M2P_ENTRY);
..

I'd like you to reconsider it. Since there is a dislike using is_pvh, 
I suppose one alternative could be, 'if ( gfn_p2mt == p2m_mmio_direct)'.

If you have any other suggestions, I'm open to them. LMK your thoughts..

Thanks,
Mukesh

             reply	other threads:[~2014-06-04  1:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04  1:29 Mukesh Rathor [this message]
2014-06-04  7:33 ` pvh dom0: memory leak from iomem map Jan Beulich
2014-06-04 23:32   ` Mukesh Rathor
2014-06-05  6:33     ` Jan Beulich
2014-06-05 10:17     ` Roger Pau Monné
2014-06-05 10:29       ` Jan Beulich
2014-06-06  2:04       ` Mukesh Rathor
2014-06-05  9:20 ` Tim Deegan
2014-06-06  2:12   ` Mukesh Rathor
2014-06-06  9:53     ` Tim Deegan
2014-06-06 19:36       ` Mukesh Rathor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140603182948.073180cf@mantra.us.oracle.com \
    --to=mukesh.rathor@oracle.com \
    --cc=JBeulich@suse.com \
    --cc=Xen-devel@lists.xensource.com \
    --cc=tim@xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).