From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: pvh dom0: memory leak from iomem map
Date: Tue, 3 Jun 2014 18:29:48 -0700
Message-ID: <20140603182948.073180cf@mantra.us.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tim Deegan <tim@xen.org>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

Hi Tim,

When building a dom0 pvh, we populate the p2m with 0..N pfns upfront. Then
in pvh_map_all_iomem, we walk the e820 and map all iomem 1:1. As such
any iomem range below N would cause those ram frames to be silently dropped. 
Since the holes could be pretty big, I am concenred this could result
in significant loss of frames. 

In my very early patches I had:

set_typed_p2m_entry():
...
    else if ( p2m_is_ram(ot) )
    {
         if ( is_pvh_domain(d) )                    <---
             free_domheap_page(mfn_to_page(omfn));  <---

         ASSERT(mfn_valid(omfn));
         set_gpfn_from_mfn(mfn_x(omfn), INVALID_M2P_ENTRY);
..

I'd like you to reconsider it. Since there is a dislike using is_pvh, 
I suppose one alternative could be, 'if ( gfn_p2mt == p2m_mmio_direct)'.

If you have any other suggestions, I'm open to them. LMK your thoughts..

Thanks,
Mukesh