From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [V1 PATCH] PVH: avoid call to handle_mmio
Date: Wed, 4 Jun 2014 16:52:21 -0700
Message-ID: <20140604165221.1ccaa596@mantra.us.oracle.com>
References: <1401832802-27118-1-git-send-email-mukesh.rathor@oracle.com>
	<1401832802-27118-2-git-send-email-mukesh.rathor@oracle.com>
	<538EE5BF02000078000179E7@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <mukesh.rathor@oracle.com>) id 1WsKyr-0007XG-KH
	for xen-devel@lists.xenproject.org; Wed, 04 Jun 2014 23:52:29 +0000
In-Reply-To: <538EE5BF02000078000179E7@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, keir.xen@gmail.com
List-Id: xen-devel@lists.xenproject.org

On Wed, 04 Jun 2014 08:24:15 +0100
"Jan Beulich" <JBeulich@suse.com> wrote:

> >>> On 04.06.14 at 00:00, <mukesh.rathor@oracle.com> wrote:
> > handle_mmio() is currently unsafe for pvh guests. A call to it would
> > result in call to vioapic_range that will crash xen since the
> > vioapic ptr in struct hvm_domain is not initialized for pvh guests.
> > 
> > However, one path exists for such a call. If a pvh guest, dom0 or
> > domU, unintentionally touches non-existing memory, an EPT violation
> > would occur. This would result in unconditional call to
> > hvm_hap_nested_page_fault. In that function, because
> > get_gfn_type_access returns p2m_mmio_dm for non existing mfns by
> > default, handle_mmio() will get called. This would result in xen
> > crash instead of the guest crash. This patch addresses that.
> 
> Yes, we definitely want this until being properly handled, no matter
> that crashing the guest here doesn't seem to be the right thing either
> (normal x86 behavior would be to drop writes and return all ones for
> reads).

How about doing the same we do for HVM which is inject GP. Then handle_mmio
would just return 0 for pvh, and hvm_hap_nested_page_fault would not need
to be modified.

Mukesh