From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com
Subject: Re: [PATCH v1 1/2] libxl: give pciback a chance to do its teardown before we reset the device.
Date: Thu, 5 Jun 2014 13:41:42 -0400 [thread overview]
Message-ID: <20140605174142.GB2546@localhost.localdomain> (raw)
In-Reply-To: <1401965922.29759.6.camel@kazak.uk.xensource.com>
On Thu, Jun 05, 2014 at 11:58:42AM +0100, Ian Campbell wrote:
> On Wed, 2014-06-04 at 09:33 -0400, Konrad Rzeszutek Wilk wrote:
> > We try to reset the device before we signal the pciback that
> > the device is no longer to be used by the guest. As such
> > we should give the pciback (or QEMU) a chance first to
> > some cleanup before we deploy the sledghammer approach
> > of resetting the device.
>
> What does "a chance" correspond to here? Do we wait for some defined
> time for the state node to hit closed or are we now relying in winning a
> race more often than before?
>
> I think we would obviously prefer the former, meaning there should be a
> call to libxl__wait_for_backend("6") in here somewhere I think.
Yeah, that would be smarter.
>
> Ian.
>
next prev parent reply other threads:[~2014-06-05 17:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 13:33 [PATCH v1] Misc fixes to libxl (v1) Konrad Rzeszutek Wilk
2014-06-04 13:33 ` [PATCH v1 1/2] libxl: give pciback a chance to do its teardown before we reset the device Konrad Rzeszutek Wilk
2014-06-05 10:58 ` Ian Campbell
2014-06-05 17:41 ` Konrad Rzeszutek Wilk [this message]
2014-06-05 17:56 ` Ian Jackson
2014-06-06 9:07 ` Ian Campbell
2014-06-04 13:33 ` [PATCH v1 2/2] libxl: vcpu-set - allow to decrease vcpu count on overcommitted guests (v2) Konrad Rzeszutek Wilk
2014-06-05 11:02 ` Ian Campbell
2014-06-05 17:44 ` Konrad Rzeszutek Wilk
2014-06-06 9:07 ` Ian Campbell
2015-02-02 20:47 ` Konrad Rzeszutek Wilk
2015-02-02 20:47 ` [PATCH 1/4] libxl: vcpuset: Return error values Konrad Rzeszutek Wilk
2015-02-03 11:29 ` Ian Jackson
2015-02-02 20:47 ` [PATCH 2/4] libxl: vcpuset: Check max_vcpus argument against the maximum number of vCPUs the guest has set Konrad Rzeszutek Wilk
2015-02-03 15:11 ` Ian Jackson
2015-02-03 15:45 ` Konrad Rzeszutek Wilk
2015-03-11 10:56 ` Ian Campbell
2015-02-02 20:47 ` [PATCH 3/4] libxl: vcpuset: Remove useless limit on max_vcpus Konrad Rzeszutek Wilk
2015-02-02 20:47 ` [PATCH 4/4] libxl: vcpu-set - allow to decrease vcpu count on overcommitted guests (v3) Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605174142.GB2546@localhost.localdomain \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).