From: Olaf Hering <olaf@aepfle.de>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v6] libxl: add option for discard support to xl disk configuration
Date: Tue, 17 Jun 2014 10:45:39 +0200 [thread overview]
Message-ID: <20140617084539.GA6558@aepfle.de> (raw)
In-Reply-To: <1402993646.16844.5.camel@kazak.uk.xensource.com>
On Tue, Jun 17, Ian Campbell wrote:
> On Tue, 2014-06-17 at 08:36 +0200, Olaf Hering wrote:
> > +++ b/tools/libxl/libxl.c
> > @@ -2292,6 +2292,9 @@ int libxl__device_disk_setdefault(libxl__gc *gc, libxl_device_disk *disk)
> > {
> > int rc;
> >
> > + if (!libxl_defbool_is_default(disk->discard_enable))
> > + libxl_defbool_setdefault(&disk->discard_enable, !!disk->readwrite);
> No need for the condition here, setdefault already incorporates it.
>
> I think with that changed this is probably the right fix.
I sent an fix: 'libxl: properly set default of discard_enable'.
Olaf
prev parent reply other threads:[~2014-06-17 8:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 9:50 [PATCH v6] libxl: add option for discard support to xl disk configuration Olaf Hering
2014-05-19 11:51 ` Ian Jackson
2014-05-19 13:01 ` Olaf Hering
2014-05-19 14:24 ` Ian Jackson
2014-05-19 14:32 ` Olaf Hering
2014-06-16 16:27 ` Ian Campbell
2014-06-17 6:36 ` Olaf Hering
2014-06-17 8:27 ` Ian Campbell
2014-06-17 8:45 ` Olaf Hering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617084539.GA6558@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).