Re: [PATCH v6 13/13] systemd: add xen systemd service and module files

[Bastian Blank <bastian@waldi.eu.org>]

On Thu, Jun 12, 2014 at 06:18:51PM -0700, Luis R. Rodriguez wrote:
> This adds the systemd xen service / module files. All of this
> is disabled for now, and won't install / build until we hook
> up proper support for systemd into the build system.

Why?

> --- /dev/null
> +++ b/tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in
> @@ -0,0 +1,13 @@
> +[Unit]
> +Description=mount xenstore file system
> +ConditionVirtualization=xen

Move the whole shit to /run, as anyone else does.

> --- /dev/null
> +++ b/tools/hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service.in
> @@ -0,0 +1,22 @@
> +[Service]
> +Type=simple
> +EnvironmentFile=-/etc/default/xenstored
> +EnvironmentFile=-/etc/sysconfig/xenstored
> +PIDFile=@XEN_RUN_DIR@/qemu-dom0.pid
> +ExecStartPre=/bin/grep -q control_d /proc/xen/capabilities

This can fail and will move the unit into failed state.  Please show
that this stuff does not make failed units on non-control domains.

> +ExecStartPre=/bin/mkdir -p /var/run/xen

This is referenced nowhere.

> +ExecStart=/bin/sh -c "exec $XENSTORED --no-fork $XENSTORED_ARGS"
> +ExecStartPost=-@BINDIR@/xenstore-write "/local/domain/0/name" "Domain-0"
> +ExecStartPost=-@BINDIR@/xenstore-write "/local/domain/0/domid" 0

Are you sure this is not racey?

Bastian

-- 
There is an order of things in this universe.
		-- Apollo, "Who Mourns for Adonais?" stardate 3468.1