From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastian Blank <bastian@waldi.eu.org>
Subject: Re: [PATCH v6 13/13] systemd: add xen systemd service
 and module files
Date: Thu, 19 Jun 2014 21:47:30 +0200
Message-ID: <20140619194730.GA6266@mail.waldi.eu.org>
References: <1402622331-4282-1-git-send-email-mcgrof@do-not-panic.com>
	<1402622331-4282-14-git-send-email-mcgrof@do-not-panic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <bastian@waldi.eu.org>) id 1WxiJ5-0002kG-K1
	for xen-devel@lists.xenproject.org; Thu, 19 Jun 2014 19:47:35 +0000
Content-Disposition: inline
In-Reply-To: <1402622331-4282-14-git-send-email-mcgrof@do-not-panic.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, "Luis R. Rodriguez" <mcgrof@suse.com>, Jan =?utf-8?Q?R=C4=99korajski?= <baggins@pld-linux.org>, Ian Jackson <ian.jackson@eu.citrix.com>, Jacek Konieczny <jajcus@jajcus.net>, M A Young <m.a.young@durham.ac.uk>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Thu, Jun 12, 2014 at 06:18:51PM -0700, Luis R. Rodriguez wrote:
> This adds the systemd xen service / module files. All of this
> is disabled for now, and won't install / build until we hook
> up proper support for systemd into the build system.

Why?

> --- /dev/null
> +++ b/tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in
> @@ -0,0 +1,13 @@
> +[Unit]
> +Description=mount xenstore file system
> +ConditionVirtualization=xen

Move the whole shit to /run, as anyone else does.

> --- /dev/null
> +++ b/tools/hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service.in
> @@ -0,0 +1,22 @@
> +[Service]
> +Type=simple
> +EnvironmentFile=-/etc/default/xenstored
> +EnvironmentFile=-/etc/sysconfig/xenstored
> +PIDFile=@XEN_RUN_DIR@/qemu-dom0.pid
> +ExecStartPre=/bin/grep -q control_d /proc/xen/capabilities

This can fail and will move the unit into failed state.  Please show
that this stuff does not make failed units on non-control domains.

> +ExecStartPre=/bin/mkdir -p /var/run/xen

This is referenced nowhere.

> +ExecStart=/bin/sh -c "exec $XENSTORED --no-fork $XENSTORED_ARGS"
> +ExecStartPost=-@BINDIR@/xenstore-write "/local/domain/0/name" "Domain-0"
> +ExecStartPost=-@BINDIR@/xenstore-write "/local/domain/0/domid" 0

Are you sure this is not racey?

Bastian

-- 
There is an order of things in this universe.
		-- Apollo, "Who Mourns for Adonais?" stardate 3468.1