From: Dario Faggioli <dario.faggioli@citrix.com>
To: xen-devel@lists.xen.org
Cc: Ian.Jackson@citrix.com, Wei Liu <wei.liu2@citrix.com>,
Ian.Campbell@citrix.com,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [PATCH RFC 8/9] mg-unixbench-download: make it generic
Date: Thu, 26 Jun 2014 15:03:20 +0200 [thread overview]
Message-ID: <20140626130320.20110.90515.stgit@Solace> (raw)
In-Reply-To: <20140626124540.20110.24159.stgit@Solace>
so that it can handle the retrieval of different
benchmarks. The name of the benchmark to fetch should
be among the supported one, and is passed as an argument.
XXX This is a stab. As detailed in the cover letter, I
just wanted to give an idea of how things would look
like, if we take this path. I personally prefer it
like this, but let's talk about it.
Of course, if we decide to go this way, the name
will be changed from mg-unixbench-download to
mg-bench-download, and I'll structure the file
like this from the beginning.
Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
---
ap-common | 4 ++++
mg-unixbench-download | 19 +++++++++++++++++--
2 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/ap-common b/ap-common
index 000ca69..ff0f205 100644
--- a/ap-common
+++ b/ap-common
@@ -140,3 +140,7 @@ info_linux_tree () {
# UnixBench. By default we try to grab version 5.1.3
: ${REMOTEFILE_UNIXBENCH:=http://byte-unixbench.googlecode.com/files/unixbench-5.1.3.tgz}
: ${LOCALFILE_UNIXBENCH:=unixbench.tgz}
+
+# hackbench. By default, directly from mingo page!
+: ${REMOTEFILE_HACKBENCH:=http://people.redhat.com/mingo/cfs-scheduler/tools/hackbench.c}
+: ${LOCALFILE_HACKBENCH:=hackbench.c}
diff --git a/mg-unixbench-download b/mg-unixbench-download
index 891b0b1..c4d5ab3 100755
--- a/mg-unixbench-download
+++ b/mg-unixbench-download
@@ -30,5 +30,20 @@ images=`getconfig Images`;
dstdir="${images}/benchs"
mkdir -p $dstdir
-wget ${REMOTEFILE_UNIXBENCH} -O ${dstdir}/${LOCALFILE_UNIXBENCH} || \
- fail "failed downloading the benchmark"
+for bench in "$@"; do
+ case $bench in
+ unixbench)
+ bench_url=${REMOTEFILE_UNIXBENCH}
+ bench_dst=${dstdir}/${LOCALFILE_UNIXBENCH}
+ ;;
+ hackbench)
+ bench_url=${REMOTEFILE_HACKBENCH}
+ bench_dst=${dstdir}/${LOCALFILE_HACKBENCH}
+ ;;
+ *)
+ fail "unknown benchmark $bench"
+ ;;
+ esac
+
+ wget ${bench_url} -O ${bench_dst} || fail "failed downloading ${bench}"
+done
next prev parent reply other threads:[~2014-06-26 13:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 13:02 [PATCH RFC 0/9] Running benchmarks via OSSTest Dario Faggioli
2014-06-26 13:02 ` [PATCH RFC 1/9] mg-unixbench-download: new script for downloading the unixbench archive Dario Faggioli
2014-07-16 15:02 ` Ian Campbell
2014-07-16 16:08 ` Dario Faggioli
2014-06-26 13:02 ` [PATCH RFC 2/9] ts-unixbench-prep: prep the environment for running unixbench Dario Faggioli
2014-07-16 15:09 ` Ian Campbell
2014-07-16 15:11 ` Ian Jackson
2014-07-16 15:57 ` Dario Faggioli
2014-07-16 16:07 ` Dario Faggioli
2014-06-26 13:02 ` [PATCH RFC 3/9] ts-unixbench-run: kick off the benchmark on the target Dario Faggioli
2014-06-26 13:02 ` [PATCH RFC 4/9] ts-unixbench-reslts: for retrieving the results Dario Faggioli
2014-07-16 15:11 ` Ian Campbell
2014-07-16 15:58 ` Dario Faggioli
2014-06-26 13:02 ` [PATCH RFC 5/9] sg-run-job: new recipe for a unixbench job Dario Faggioli
2014-06-26 13:03 ` [PATCH RFC 6/9] make-bench-flight: to create a benchmarking flight Dario Faggioli
2014-06-26 13:03 ` [PATCH RFC 7/9] make-flight: introduce a new -t option Dario Faggioli
2014-07-16 15:13 ` Ian Campbell
2014-07-16 15:14 ` Dario Faggioli
2014-06-26 13:03 ` Dario Faggioli [this message]
2014-06-26 13:03 ` [PATCH RFC 9/9] ts-unixbench-prep: make it generic Dario Faggioli
2014-06-27 9:40 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626130320.20110.90515.stgit@Solace \
--to=dario.faggioli@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).