From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Luis R. Rodriguez" <mcgrof@suse.com>
Subject: Re: [PATCH v6 10/13] autoconf: xen: move standard path
	variables	to config/Paths.mk.in
Date: Tue, 8 Jul 2014 20:41:09 +0200
Message-ID: <20140708184109.GO27687@wotan.suse.de>
References: <1402622331-4282-1-git-send-email-mcgrof@do-not-panic.com>
	<1402622331-4282-11-git-send-email-mcgrof@do-not-panic.com>
	<1404308054.5562.82.camel@kazak.uk.xensource.com>
	<20140702193219.GX27687@wotan.suse.de>
	<1404378913.14865.9.camel@kazak.uk.xensource.com>
	<20140703183029.GH27687@wotan.suse.de>
	<1404484435.14796.34.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <lurodriguez@suse.de>) id 1X4aKH-0003Ux-Hk
	for xen-devel@lists.xenproject.org; Tue, 08 Jul 2014 18:41:13 +0000
Content-Disposition: inline
In-Reply-To: <1404484435.14796.34.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Keir Fraser <keir@xen.org>, "Luis R. Rodriguez" <mcgrof@do-not-panic.com>, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, Jan Beulich <jbeulich@suse.com>, Samuel Thibault <samuel.thibault@ens-lyon.org>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Fri, Jul 04, 2014 at 03:33:55PM +0100, Ian Campbell wrote:
> On Thu, 2014-07-03 at 20:30 +0200, Luis R. Rodriguez wrote:
> > On Thu, Jul 03, 2014 at 10:15:13AM +0100, Ian Campbell wrote:
> > > On Wed, 2014-07-02 at 21:32 +0200, Luis R. Rodriguez wrote:
> > > > On Wed, Jul 02, 2014 at 02:34:14PM +0100, Ian Campbell wrote:
> > > > > On Thu, 2014-06-12 at 18:18 -0700, Luis R. Rodriguez wrote:
> > > > > > diff --git a/m4/paths.m4 b/m4/paths.m4
> > > > > > new file mode 100644
> > > > > > index 0000000..717fcd1
> > > > > > --- /dev/null
> > > > > > +++ b/m4/paths.m4
> > > > > > @@ -0,0 +1,61 @@
> > > > > > +AC_DEFUN([AX_XEN_EXPAND_CONFIG], [
> > > > > > +dnl expand these early so we can use this for substitutions
> > > > > > +test "x$prefix" = "xNONE" && prefix=$ac_default_prefix
> > > > > > +test "x$exec_prefix" = "xNONE" && exec_prefix=$ac_default_prefix
> > > > > 
> > > > > This is a bit of shame. I suppose this needs to happen in the middle of
> > > > > AC_OUTPUT which isn't possible?
> > > > > 
> > > > > autoconf itself seems to quote the prefix so it is not expanded until
> > > > > later, i.e. when config.status is run. Would that work here?
> > > > 
> > > > Its unclear what exactly the recommendation is here.
> > > > 
> > > > > Or perhaps we should just PREFIX=$prefix AC_SUBST(PREFIX) and put all
> > > > > the BINDIR=$PREFIX/bin into Paths.mk.in after PREFIX=@PREFIX@?
> > > > 
> > > > Why though?
> > > 
> > > To avoid cutting and pasting the snippet of autoconf internal code:
> > >         test "x$prefix" = "xNONE" && prefix=$ac_default_prefix
> > > into our m4 code.
> > 
> > Ah but that would mean not being able to use --prefix then no?
> 
> I hope not.
> 
> autoconf generates this snippet in configure itself, by deferring the
> evaluation of things I'm hoping that the content of Paths.mk.in can be
> evaluated after that snippet has run.

You're right, this works. OK Great.

  Luis