From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Luis R. Rodriguez" <mcgrof@suse.com>
Subject: Re: [PATCH v6 10/13] autoconf: xen: move standard path
	variables	to config/Paths.mk.in
Date: Tue, 8 Jul 2014 20:52:18 +0200
Message-ID: <20140708185218.GP27687@wotan.suse.de>
References: <1402622331-4282-1-git-send-email-mcgrof@do-not-panic.com>
	<1402622331-4282-11-git-send-email-mcgrof@do-not-panic.com>
	<1404308054.5562.82.camel@kazak.uk.xensource.com>
	<20140703185343.GI27687@wotan.suse.de>
	<1404484560.14796.35.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <lurodriguez@suse.de>) id 1X4aV2-0004Oa-HV
	for xen-devel@lists.xenproject.org; Tue, 08 Jul 2014 18:52:20 +0000
Content-Disposition: inline
In-Reply-To: <1404484560.14796.35.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Keir Fraser <keir@xen.org>, "Luis R. Rodriguez" <mcgrof@do-not-panic.com>, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, Jan Beulich <jbeulich@suse.com>, Samuel Thibault <samuel.thibault@ens-lyon.org>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Fri, Jul 04, 2014 at 03:36:00PM +0100, Ian Campbell wrote:
> On Thu, 2014-07-03 at 20:53 +0200, Luis R. Rodriguez wrote:
> > On Wed, Jul 02, 2014 at 02:34:14PM +0100, Ian Campbell wrote:
> > > On Thu, 2014-06-12 at 18:18 -0700, Luis R. Rodriguez wrote:
> > > > From: "Luis R. Rodriguez" <mcgrof@suse.com>
> > > > +LIBDIR=`eval echo $libdir`
> > > 
> > > Why is this one an eval?
> > 
> > BTW I now see why I had used the eval on LIBDIR, its because otherwise Paths.mk
> > ends up with:
> > 
> > LIBDIR                   := ${exec_prefix}/lib64
> > ...
> > PRIVATE_PREFIX           := ${exec_prefix}/lib64/xen
> > PRIVATE_PREFIX           := ${exec_prefix}/lib64/xen
> > PRIVATE_BINDIR           := ${exec_prefix}/lib64/xen/bin
> > ...
> > 
> > Can I upkeep the eval?
> 
> Seems a bit odd that this would only affect LIBDIR and not PREFIX.

Yeah I tested this, the substitution does not happen even if I use
AC_SUBST(exec_prefix).

> I'd like to understand why this happens before reaching for the eval (or
> to see some autoconf documentation that claims this is the right thing
> to do).

Um, OK. So this patch series will have to wait then until that's done.
I'm not sure I can help much here.

  Luis