From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Subject: Re: [PATCH v6 12/13] autoconf: xen: enable explicit preference option for xenstored preference Date: Tue, 8 Jul 2014 20:54:54 +0200 Message-ID: <20140708185454.GR27687@wotan.suse.de> References: <1402622331-4282-1-git-send-email-mcgrof@do-not-panic.com> <1402622331-4282-13-git-send-email-mcgrof@do-not-panic.com> <1404309271.5562.96.camel@kazak.uk.xensource.com> <20140702200911.GY27687@wotan.suse.de> <1404379240.14865.15.camel@kazak.uk.xensource.com> <20140703185755.GJ27687@wotan.suse.de> <1404484643.14796.37.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1X4aXY-0004l0-VX for xen-devel@lists.xenproject.org; Tue, 08 Jul 2014 18:54:57 +0000 Content-Disposition: inline In-Reply-To: <1404484643.14796.37.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Keir Fraser , "Luis R. Rodriguez" , Tim Deegan , Ian Jackson , Jan Beulich , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Fri, Jul 04, 2014 at 03:37:23PM +0100, Ian Campbell wrote: > On Thu, 2014-07-03 at 20:57 +0200, Luis R. Rodriguez wrote: > > > > Strictly speaking you don't > > > need the associated AC_SUBST's but they are harmless. > > > > Without the AC_SUBST() I do not believe substitiution is done by > > autoconf on Paths.mk. > > For tools/configure you won't be creating Paths.mk, so it doesn't > matter. > > > OK so use AX_XEN_EXPAND_CONFIG() on both top level configure.ac and > > tools/configure.ac but only have config/Paths.mk be a AC_CONFIG_FILES() > > for the top level configure.ac ? > OK that's exactly how the patch was so I'll leave it alone. Luis