From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH v3 2/6] xen: arm: Handle 4K aligned hypervisor load address. Date: Mon, 21 Jul 2014 15:20:14 +0200 Message-ID: <20140721132014.GC40391@deinos.phlegethon.org> References: <1405947513.25022.59.camel@kazak.uk.xensource.com> <1405947600-26047-1-git-send-email-ian.campbell@citrix.com> <1405947600-26047-2-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1405947600-26047-2-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, julien.grall@linaro.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org At 13:59 +0100 on 21 Jul (1405947596), Ian Campbell wrote: > +virtphys_clash: > + /* Identity map clashes with boot_third, which we cannot handle yet */ > + PRINT("Unable to build boot page tables - virt and phys addresses clash.\r\n") Please tag this string "- Like so -\r\n" to match the other early output from the boot assembler. Presumably we could get around this by making a 4k mapping when the 2M mapping would clash (at the cost of some extra code)? Not suggesting that it's necessary in this version. Tim.