xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: annie li <annie.li@oracle.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	"Wei Liu" <wei.liu2@citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: Rebooting domu fails in nfs share exported from another domu on the same dom0
Date: Tue, 22 Jul 2014 00:05:58 +0100	[thread overview]
Message-ID: <20140721230558.GA13229@zion.uk.xensource.com> (raw)
In-Reply-To: <53CD2B9E.60706@oracle.com>

On Mon, Jul 21, 2014 at 11:02:54AM -0400, annie li wrote:
[...]
> >>>being the source it is the C guest (vm2)? Thought I don't know if
> >>>the hypercall allows us to make a grant_copy on behalf of two
> >>>other guests.
> >>Oh... I remember netback did have some grant_copy code on behalf of two
> >>guests on same server, and it was removed later on. So I think grantcopy
> >>A->C works for this case with the precondition that we can recognize this
> >>page is mapped from another guest.
> >>
> >I have not followed this thread closely.
> >
> >The tracking facility was removed because it was dead at that time. See
> >43e9d19 ("xen-netback: remove page tracking facility").
> >
> >However I think the latest netback with mapping scheme does have
> >something similar. I can see there's a "foreign_queue" check in
> >xenvif_gop_frag_copy. Is that not enough?
> 
> Correct, this mapping scheme does similar thing, but it is for communication
> between two vifs on the same server, the original page is mapped by netback
> tx path. Here, this issue is caused when the page mapped by blkback.
> 

I see.

> What I am thinking is:  checking whether the page is mapped, if yes, then
> does grant copy from source to dest directly instead of Dom0->dest since a
> condition check fails in mm.c if the original page is from another vm for
> situation Dom0->dist .
> 

The foreign frame is marked with FOREIGN_FRAME_BIT in p2m code so you
can probably make use of that? However gref is not embedded in struct
page.

Wei.

> Thanks
> Annie

  reply	other threads:[~2014-07-21 23:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16 20:36 Rebooting domu fails in nfs share exported from another domu on the same dom0 annie li
2014-07-17 15:49 ` Roger Pau Monné
2014-07-17 16:56   ` annie li
2014-07-18 18:53     ` Konrad Rzeszutek Wilk
2014-07-18 19:31       ` annie li
2014-07-18 19:43         ` Konrad Rzeszutek Wilk
2014-07-18 20:17           ` annie li
2014-07-18 20:22             ` Konrad Rzeszutek Wilk
2014-07-18 20:31               ` annie li
2014-07-18 21:07                 ` Konrad Rzeszutek Wilk
2014-07-18 21:43                   ` annie li
2014-07-21 10:02                     ` Wei Liu
2014-07-21 15:02                       ` annie li
2014-07-21 23:05                         ` Wei Liu [this message]
2014-07-23  1:58                           ` annie li
2014-07-28 14:14 ` David Vrabel
2014-07-28 16:14   ` annie li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140721230558.GA13229@zion.uk.xensource.com \
    --to=wei.liu2@citrix.com \
    --cc=annie.li@oracle.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).