From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Luis R. Rodriguez" <mcgrof@suse.com>
Subject: Re: [PATCH v7 7/8] autoconf: xen: enable
	explicit	preference option for xenstored preference
Date: Sat, 26 Jul 2014 01:25:00 +0200
Message-ID: <20140725232500.GE4191@wotan.suse.de>
References: <1405639699-13494-1-git-send-email-mcgrof@do-not-panic.com>
	<1405639699-13494-8-git-send-email-mcgrof@do-not-panic.com>
	<1406216446.25535.24.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <lurodriguez@suse.de>) id 1XAorH-00070J-U4
	for xen-devel@lists.xenproject.org; Fri, 25 Jul 2014 23:25:09 +0000
Content-Disposition: inline
In-Reply-To: <1406216446.25535.24.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Keir Fraser <keir@xen.org>, "Luis R. Rodriguez" <mcgrof@do-not-panic.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Thu, Jul 24, 2014 at 04:40:46PM +0100, Ian Campbell wrote:
> On Thu, 2014-07-17 at 16:28 -0700, Luis R. Rodriguez wrote:
> > +This file has one relevant variables
> 
> just "variable"
> 
> > which is specific to the version of xenstored used:
> 
> I'm not sure what you mean by this. The variable isn't specific to
> either version, it's the path of whichever one. I think you can drop
> that entire clause.

OK. Dropped.

> > -# Select xenstored implementation
> > -#XENSTORED=[oxenstored|xenstored]
> > +# Select xenstore implementation, this can be either
> > +# of these below. If using systemd it's preferred that you
> > +# just edit the xenstored.service unit file and change
> > +# the XENSTORED variable there.
> > +#
> > +# This can be either of:
> > +#  * @SBINDIR@/oxenstored
> > +#  * @SBINDIR@/xenstored
> 
> Does it need to be the full path or is $PATH searched?

The full path is preferred, on legacy init the variable is used
to execute alone, but of course the path will be searched. For
systemd exec $XENSTORED is used, that looks on the path as well.
I think its best to specifcy the full path to be safe and explicit.

  Luis