From: Olaf Hering <olaf@aepfle.de>
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] tools/mkrpm: allow custom rpm package name
Date: Wed, 30 Jul 2014 17:34:28 +0200 [thread overview]
Message-ID: <20140730153428.GA11138@aepfle.de> (raw)
In-Reply-To: <53D908FB.9030200@eu.citrix.com>
On Wed, Jul 30, George Dunlap wrote:
> So my recent "make src-tarball" patches I had two build targets: one where
> it would make a tarball with a "release-like" name based on "make -C xen
> version" (e.g., xen-4.4.1.tar.gz), and another where it would make a tarball
> with a "developer-like" version based on "git describe". You might think
> about adding an option like that to the rpm / deb make targets as well, so
> you don't have to invent your own name / remember what changeset a
> particular rpm is based on.
Are you saying there should be a 'make distpkg GITREV=<rev|tag>'?
For me the "name info" is in my wrapper script, which sets both
--prefix=/some/xen/suffix during configure and the package name during
make. The rpm release is just 'date +%s' to make 'rpm -F *.rpm' easier.
The changeset info is most likely bogus due to repeated 'git rebase'.
Olaf
prev parent reply other threads:[~2014-07-30 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 10:19 [PATCH] tools/mkrpm: allow custom rpm package name Olaf Hering
2014-07-30 13:08 ` George Dunlap
2014-07-30 13:21 ` Olaf Hering
2014-07-30 13:42 ` Ian Campbell
2014-07-30 14:06 ` Olaf Hering
2014-07-30 15:02 ` George Dunlap
2014-07-30 15:34 ` Olaf Hering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140730153428.GA11138@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).