From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Subject: Re: [PATCH v8 0/6] xen: systemd support Date: Wed, 30 Jul 2014 18:22:13 +0200 Message-ID: <20140730162213.GV21930@wotan.suse.de> References: <1406340860-8547-1-git-send-email-mcgrof@do-not-panic.com> <1406551592.14628.15.camel@kazak.uk.xensource.com> <20140728150215.GA21930@wotan.suse.de> <1406559951.16498.6.camel@kazak.uk.xensource.com> <20140728175719.GH21930@wotan.suse.de> <1406624199.20809.9.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XCWds-0005Cg-Hs for xen-devel@lists.xenproject.org; Wed, 30 Jul 2014 16:22:16 +0000 Content-Disposition: inline In-Reply-To: <1406624199.20809.9.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, "Luis R. Rodriguez" List-Id: xen-devel@lists.xenproject.org On Tue, Jul 29, 2014 at 09:56:39AM +0100, Ian Campbell wrote: > On Mon, 2014-07-28 at 19:57 +0200, Luis R. Rodriguez wrote: > > On Mon, Jul 28, 2014 at 04:05:51PM +0100, Ian Campbell wrote: > > > On Mon, 2014-07-28 at 17:02 +0200, Luis R. Rodriguez wrote: > > > > On Mon, Jul 28, 2014 at 01:46:32PM +0100, Ian Campbell wrote: > > > > > On Fri, 2014-07-25 at 19:14 -0700, Luis R. Rodriguez wrote: > > > > > > From: "Luis R. Rodriguez" > > > > > > > > > > > > Here's my v8 series. Quite a bit of patches are alreayd merged > > > > > > on the xen origin/staging branch, this addresses the last feedback > > > > > > from the v7 series and is rebased. It contains two fixes spotted > > > > > > as possible issues by Ian Campbell. > > > > > > > > > > > > I think this is it, after about 2 months of spinning patches. Phew. > > > > > > > > > > I was about to ack and apply the lot when I noticed that > > > > > dist/install/etc/init.d/xencommons was an empty file. > > > > > > > > The file tools/hotplug/Linux/update-modules.sh must be chmod 755 > > > > > > I observed the git diff had the mode in it, so I assumed that git am > > > would have done the right thing. I didn't check directly but I did look > > > at the build log which didn't show it failing to run the script (which > > > in any case should have caused the build to fail) > > > > > > > and I thought I did that on the series, I just double checked and > > > > it is indeed in the right mode on the v8 patch so not sure what > > > > could have gone wrong here. Sorry about that I could have sworn > > > > I had tested that particular case... I'm pretty sure I did. Will > > > > reseting / poke around. > > > > > > Thanks. > > > > OK I see now what happed. In my tests I had exported XENCOMMONS_INITD > > locally to run and test the shell script from the shell and later > > make -C tools/hotplug/Linux. This worked as I exported it manually but > > without that we need to expicitly do that then on the Makefile now or > > pass it as an argument. Exporting seems easier. Will rebase and send > > last batch with this hunk merged. > > I'd prefer the script to take this as an argument for clarity. OK done. > Also, you should probably invoke the script with $(BASH), else IIRC you > will break *BSD (where bash is in ports not /bin) > > Ian. This is a Linux script though, I'll use #!/usr/bin/env bash instead then. Luis