From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Subject: Re: [PATCH v8 0/6] xen: systemd support Date: Wed, 30 Jul 2014 18:43:38 +0200 Message-ID: <20140730164338.GW21930@wotan.suse.de> References: <1406340860-8547-1-git-send-email-mcgrof@do-not-panic.com> <1406551592.14628.15.camel@kazak.uk.xensource.com> <20140728150215.GA21930@wotan.suse.de> <1406559951.16498.6.camel@kazak.uk.xensource.com> <20140728175719.GH21930@wotan.suse.de> <1406624199.20809.9.camel@kazak.uk.xensource.com> <20140730162213.GV21930@wotan.suse.de> <1406737540.29218.1.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XCWya-0007Ph-CD for xen-devel@lists.xenproject.org; Wed, 30 Jul 2014 16:43:40 +0000 Content-Disposition: inline In-Reply-To: <1406737540.29218.1.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, "Luis R. Rodriguez" List-Id: xen-devel@lists.xenproject.org On Wed, Jul 30, 2014 at 05:25:40PM +0100, Ian Campbell wrote: > On Wed, 2014-07-30 at 18:22 +0200, Luis R. Rodriguez wrote: > > > > Also, you should probably invoke the script with $(BASH), else IIRC you > > > will break *BSD (where bash is in ports not /bin) > > > This is a Linux script though, > > True. > > > I'll use #!/usr/bin/env bash > > instead then. > > That's worse than either $(BASH) or a normal #! IMHO. Do you mean to call $BASH foo.sh on the makefile ? On Linux we can run scripts often on Makefiles with either #!/bin/bash or the env thing just fine. I've never actually have seen the use of $(BASH) foo.sh within the Makefile. I promise to address issues if found with this approach. Luis