xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: David Vrabel <david.vrabel@citrix.com>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
	"Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>
Subject: linux PVH broken in 3.16.0-rc7 (arch_gnttab_map_shared)
Date: Fri, 1 Aug 2014 16:46:19 -0700	[thread overview]
Message-ID: <20140801164619.1a586561@mantra.us.oracle.com> (raw)

Hi,

Not sure if this already got reported, but it appears 

commit b7dd0e3
Author: David Vrabel <david.vrabel@citrix.com>
Date:   Fri Jul 11 16:42:34 2014 +0100

    x86/xen: safely map and unmap grant frames when in atomic context

has broken boot of domU PVH. The reason being arch_gnttab_map_shared
is getting called before gnttab_shared_vm_area gets initialized by
arch_gnttab_init(). As the comment says,

--->
/* Call it _before_ __gnttab_init as we need to initialize the
 *  * xen_auto_xlat_grant_frames first. */
core_initcall(xen_pvh_gnttab_setup);
<---

we can't wait till arch_gnttab_init is called by __gnttab_init().

I'm also wondering why didn't this get caught by a simple boot test
of PVH domU before this code was merged? 

thanks,
Mukesh

             reply	other threads:[~2014-08-01 23:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01 23:46 Mukesh Rathor [this message]
2014-08-04 10:33 ` linux PVH broken in 3.16.0-rc7 (arch_gnttab_map_shared) David Vrabel
2014-08-04 14:46   ` Konrad Rzeszutek Wilk
2014-08-05 11:00 ` David Vrabel
2014-08-06 21:23   ` Mukesh Rathor
2014-08-07  1:44     ` Konrad Rzeszutek Wilk
2014-08-07  9:44     ` David Vrabel
2014-08-07 23:45     ` Mukesh Rathor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140801164619.1a586561@mantra.us.oracle.com \
    --to=mukesh.rathor@oracle.com \
    --cc=Xen-devel@lists.xensource.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).