From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: linux PVH broken in 3.16.0-rc7 (arch_gnttab_map_shared)
Date: Fri, 1 Aug 2014 16:46:19 -0700
Message-ID: <20140801164619.1a586561@mantra.us.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>, "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>, "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Hi,

Not sure if this already got reported, but it appears 

commit b7dd0e3
Author: David Vrabel <david.vrabel@citrix.com>
Date:   Fri Jul 11 16:42:34 2014 +0100

    x86/xen: safely map and unmap grant frames when in atomic context

has broken boot of domU PVH. The reason being arch_gnttab_map_shared
is getting called before gnttab_shared_vm_area gets initialized by
arch_gnttab_init(). As the comment says,

--->
/* Call it _before_ __gnttab_init as we need to initialize the
 *  * xen_auto_xlat_grant_frames first. */
core_initcall(xen_pvh_gnttab_setup);
<---

we can't wait till arch_gnttab_init is called by __gnttab_init().

I'm also wondering why didn't this get caught by a simple boot test
of PVH domU before this code was merged? 

thanks,
Mukesh