xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Matt Wilson <msw@linux.com>
To: Matt Rushton <mvrushton@gmail.com>
Cc: konrad.wilk@oracle.com, boris.ostrovsky@oracle.com,
	david.vrabel@citrix.com, msw@amazon.com,
	linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
	Matt Rushton <mrushton@amazon.com>
Subject: Re: [PATCH v3 2/2] xen/setup: Remap Xen Identity Mapped RAM
Date: Mon, 11 Aug 2014 10:41:26 -0700	[thread overview]
Message-ID: <20140811174124.GA3156@u109add4315675089e695.ant.amazon.com> (raw)
In-Reply-To: <1407778441-26604-2-git-send-email-mrushton@amazon.com>

On Mon, Aug 11, 2014 at 10:34:01AM -0700, Matt Rushton wrote:
> Instead of ballooning up and down dom0 memory this remaps the existing mfns
> that were replaced by the identity map. The reason for this is that the
> existing implementation ballooned memory up and and down which caused dom0
> to have discontiguous pages. In some cases this resulted in the use of bounce
> buffers which reduced network I/O performance significantly. This change will
> honor the existing order of the pages with the exception of some boundary
> conditions.
> 
> To do this we need to update both the Linux p2m table and the Xen m2p table.
> Particular care must be taken when updating the p2m table since it's important
> to limit table memory consumption and reuse the existing leaf pages which get
> freed when an entire leaf page is set to the identity map. To implement this,
> mapping updates are grouped into blocks with table entries getting cached
> temporarily and then released.
> 
> On my test system before:
> Total pages: 2105014
> Total contiguous: 1640635
> 
> After:
> Total pages: 2105014
> Total contiguous: 2098904
> 
> Signed-off-by: Matthew Rushton <mrushton@amazon.com>
> ---

Matt,

Could you provide a summary of v2->v3 changes here?

--msw

>  arch/x86/xen/p2m.c   |   23 +---
>  arch/x86/xen/p2m.h   |   15 ++
>  arch/x86/xen/setup.c |  370 +++++++++++++++++++++++++++++++++++++++-----------
>  3 files changed, 314 insertions(+), 94 deletions(-)
>  create mode 100644 arch/x86/xen/p2m.h

  parent reply	other threads:[~2014-08-11 17:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-11 17:34 [PATCH v3 1/2] xen/setup: Remove Identity Map Debug Message Matt Rushton
2014-08-11 17:34 ` [PATCH v3 2/2] xen/setup: Remap Xen Identity Mapped RAM Matt Rushton
2014-08-11 17:40   ` David Vrabel
2014-08-11 17:41   ` Matt Wilson [this message]
2014-08-11 19:00     ` Matthew Rushton
2014-08-27 10:28   ` David Vrabel
  -- strict thread matches above, loose matches on Subject: below --
2014-08-11 18:57 [PATCH v3 1/2] xen/setup: Remove Identity Map Debug Message Matt Rushton
2014-08-11 18:57 ` [PATCH v3 2/2] xen/setup: Remap Xen Identity Mapped RAM Matt Rushton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140811174124.GA3156@u109add4315675089e695.ant.amazon.com \
    --to=msw@linux.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mrushton@amazon.com \
    --cc=msw@amazon.com \
    --cc=mvrushton@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).