* [PATCH] xen_hvc: no reason to write the type key on xenstore
@ 2014-08-11 11:54 Stefano Stabellini
2014-08-11 11:58 ` David Vrabel
2014-08-11 14:32 ` Stefano Stabellini
0 siblings, 2 replies; 5+ messages in thread
From: Stefano Stabellini @ 2014-08-11 11:54 UTC (permalink / raw)
To: xen-devel
Cc: David Vrabel, Konrad Rzeszutek Wilk, Stefano Stabellini,
Dave Scott, linux-kernel
The backend type is chosen by the toolstack. Regardless, the frontend
should not care, especially given that it cannot have an effect as the
backend is started before this code is run.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c
index 636c9ba..b8491f5 100644
--- a/drivers/tty/hvc/hvc_xen.c
+++ b/drivers/tty/hvc/hvc_xen.c
@@ -402,9 +402,6 @@ static int xencons_connect_backend(struct xenbus_device *dev,
evtchn);
if (ret)
goto error_xenbus;
- ret = xenbus_printf(xbt, dev->nodename, "type", "ioemu");
- if (ret)
- goto error_xenbus;
ret = xenbus_transaction_end(xbt, 0);
if (ret) {
if (ret == -EAGAIN)
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] xen_hvc: no reason to write the type key on xenstore
2014-08-11 11:54 [PATCH] xen_hvc: no reason to write the type key on xenstore Stefano Stabellini
@ 2014-08-11 11:58 ` David Vrabel
2014-08-11 14:32 ` Stefano Stabellini
1 sibling, 0 replies; 5+ messages in thread
From: David Vrabel @ 2014-08-11 11:58 UTC (permalink / raw)
To: Stefano Stabellini, xen-devel
Cc: Konrad Rzeszutek Wilk, Dave Scott, linux-kernel
On 11/08/14 12:54, Stefano Stabellini wrote:
> The backend type is chosen by the toolstack. Regardless, the frontend
> should not care, especially given that it cannot have an effect as the
> backend is started before this code is run.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
This needs go via the TTY subsystem (you didn't Cc the maintainers).
David
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xen_hvc: no reason to write the type key on xenstore
2014-08-11 11:54 [PATCH] xen_hvc: no reason to write the type key on xenstore Stefano Stabellini
2014-08-11 11:58 ` David Vrabel
@ 2014-08-11 14:32 ` Stefano Stabellini
2014-08-12 2:51 ` Greg KH
1 sibling, 1 reply; 5+ messages in thread
From: Stefano Stabellini @ 2014-08-11 14:32 UTC (permalink / raw)
To: Stefano Stabellini
Cc: xen-devel, David Vrabel, Konrad Rzeszutek Wilk, Dave Scott,
linux-kernel, gregkh, jslaby
CC'ing tty maintainers.
On Mon, 11 Aug 2014, Stefano Stabellini wrote:
> The backend type is chosen by the toolstack. Regardless, the frontend
> should not care, especially given that it cannot have an effect as the
> backend is started before this code is run.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
> diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c
> index 636c9ba..b8491f5 100644
> --- a/drivers/tty/hvc/hvc_xen.c
> +++ b/drivers/tty/hvc/hvc_xen.c
> @@ -402,9 +402,6 @@ static int xencons_connect_backend(struct xenbus_device *dev,
> evtchn);
> if (ret)
> goto error_xenbus;
> - ret = xenbus_printf(xbt, dev->nodename, "type", "ioemu");
> - if (ret)
> - goto error_xenbus;
> ret = xenbus_transaction_end(xbt, 0);
> if (ret) {
> if (ret == -EAGAIN)
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] xen_hvc: no reason to write the type key on xenstore
2014-08-11 14:32 ` Stefano Stabellini
@ 2014-08-12 2:51 ` Greg KH
2014-08-12 9:06 ` Stefano Stabellini
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2014-08-12 2:51 UTC (permalink / raw)
To: Stefano Stabellini
Cc: xen-devel, David Vrabel, Konrad Rzeszutek Wilk, Dave Scott,
linux-kernel, jslaby
On Mon, Aug 11, 2014 at 03:32:48PM +0100, Stefano Stabellini wrote:
> CC'ing tty maintainers.
Why? Is that how you submit a patch to be included to the kernel tree?
(hint, the answer is no, and also you should cc: the linux-serial
list...)
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xen_hvc: no reason to write the type key on xenstore
2014-08-12 2:51 ` Greg KH
@ 2014-08-12 9:06 ` Stefano Stabellini
0 siblings, 0 replies; 5+ messages in thread
From: Stefano Stabellini @ 2014-08-12 9:06 UTC (permalink / raw)
To: Greg KH
Cc: Stefano Stabellini, xen-devel, David Vrabel,
Konrad Rzeszutek Wilk, Dave Scott, linux-kernel, jslaby
On Tue, 12 Aug 2014, Greg KH wrote:
> On Mon, Aug 11, 2014 at 03:32:48PM +0100, Stefano Stabellini wrote:
> > CC'ing tty maintainers.
>
> Why? Is that how you submit a patch to be included to the kernel tree?
> (hint, the answer is no, and also you should cc: the linux-serial
> list...)
Sorry, I resent it.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-08-12 9:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-11 11:54 [PATCH] xen_hvc: no reason to write the type key on xenstore Stefano Stabellini
2014-08-11 11:58 ` David Vrabel
2014-08-11 14:32 ` Stefano Stabellini
2014-08-12 2:51 ` Greg KH
2014-08-12 9:06 ` Stefano Stabellini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).