From: Tim Deegan <tim@xen.org>
To: Tamas K Lengyel <tamas.lengyel@zentific.com>
Cc: kevin.tian@intel.com, keir@xen.org,
suravee.suthikulpanit@amd.com, jun.nakajima@intel.com,
eddie.dong@intel.com, xen-devel@lists.xen.org,
Aravind.Gopalakrishnan@amd.com, JBeulich@suse.com,
boris.ostrovsky@oracle.com
Subject: Re: [PATCH v8 2/4] x86/hvm: Treat non-instruction fetch nested page faults also as read violations
Date: Thu, 28 Aug 2014 12:13:44 +0200 [thread overview]
Message-ID: <20140828101344.GD60905@deinos.phlegethon.org> (raw)
In-Reply-To: <1408455621-4069-2-git-send-email-tamas.lengyel@zentific.com>
At 15:40 +0200 on 19 Aug (1408459219), Tamas K Lengyel wrote:
> As pointed out by Jan Beulich in http://lists.xen.org/archives/html/xen-devel/2014-08/msg01269.html: "Read-modify-write instructions absolutely need to be treated as read accesses, yet hardware doesn't guarantee to tell us so (they may surface as just write accesses)." This patch addresses the issue in both the VMX and the SVM side.
>
> VMX: Treat all write data access violations also as read violations (in addition to those that were already reported as read violations).
> SVM: Refine the meaning of read data access violations to distinguish between read/write and instruction fetch access violations.
>
> With this patch both VMX and SVM specific nested page fault handling code reports violations the same way, thus abstracting the hardware specific behaviour from the layers above.
>
> Suggested-by: Jan Beulich <JBeulich@suse.com>
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Reviewed-by: Tim Deegan <tim@xen.org>
next prev parent reply other threads:[~2014-08-28 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 13:40 [PATCH v8 2/4] x86/hvm: Treat non-instruction fetch nested page faults also as read violations Tamas K Lengyel
2014-08-28 10:13 ` Tim Deegan [this message]
2014-08-28 21:40 ` Tian, Kevin
2014-08-29 9:49 ` Tim Deegan
2014-08-29 22:06 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140828101344.GD60905@deinos.phlegethon.org \
--to=tim@xen.org \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=eddie.dong@intel.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tamas.lengyel@zentific.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).