From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [libvirt] [libvirt bisection] complete build-armhf-libvirt Date: Tue, 9 Sep 2014 09:54:18 +0100 Message-ID: <20140909085418.GB27589@redhat.com> References: <1410252587.8217.35.camel@kazak.uk.xensource.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1410252587.8217.35.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: libvir-list@redhat.com, keir@xen.org, xen-devel@lists.xensource.com, "xen.org" , stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Tue, Sep 09, 2014 at 09:49:47AM +0100, Ian Campbell wrote: > Xen's automated testing of libvirt against newer Xen's has found a build > issue which it has bisected down to "blockcopy: expose new API in > virsh". > > An instance of the failure can be found in flight 30154: > http://lists.xen.org/archives/html/xen-devel/2014-09/msg01063.html > links to the logs => > http://www.chiark.greenend.org.uk/~xensrcts/logs/30154/ > click the header of a failing column => > http://www.chiark.greenend.org.uk/~xensrcts/logs/30154/build-armhf-libvirt/info.html > click the failing step => > http://www.chiark.greenend.org.uk/~xensrcts/logs/30154/build-armhf-libvirt/5.ts-libvirt-build.log > > virsh-domain.c: In function 'cmdBlockCopy': > virsh-domain.c:2003:17: error: comparison is always false due to limited range of data type [-Werror=type-limits] > cc1: all warnings being treated as errors > > It seems to be failing similarly on i386 and I suppose most 32-bit > arches. Thanks, we've just had a fix for that pushed commit efe5061f5a61d04b1bf21fcac2919a2325f54150 Author: Eric Blake Date: Mon Sep 8 08:50:48 2014 -0600 blockjob: avoid 32-bit compilation warning Commit c1d75de caused this warning on 32-bit platforms (fatal when -Werror is enabled): virsh-domain.c: In function 'cmdBlockCopy': virsh-domain.c:2003:17: error: comparison is always false due to limited range of data type [-Werror=type- Forcing the left side of the < to be ull instead of ul shuts up the 32-bit compiler while still protecting 64-bit code from overflow. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|