From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: missing dependency to compat/xen.h Date: Fri, 19 Sep 2014 11:28:48 +0200 Message-ID: <20140919092848.GA23249@aepfle.de> References: <20140917110104.GA27369@aepfle.de> <54198E130200007800035A72@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <54198E130200007800035A72@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, Sep 17, Jan Beulich wrote: > >>> On 17.09.14 at 13:01, wrote: > > How is compat/xen.h supposed to be created? > This make rule > > $(TARGET): delete-unfresh-files > $(MAKE) -C tools > $(MAKE) -f $(BASEDIR)/Rules.mk include/xen/compile.h > [ -e include/asm ] || ln -sf asm-$(TARGET_ARCH) include/asm > $(MAKE) -f $(BASEDIR)/Rules.mk -C include > $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) asm-offsets.s > $(MAKE) -f $(BASEDIR)/Rules.mk include/asm-$(TARGET_ARCH)/asm-offsets.h > $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $(TARGET) > > is - afaict - guaranteeing that the include/compat/ generation > happens before that of asm-offsets.s. I had a change like shown below, which confused the xen build. Meanwhile I found a way to achive my goal without such a change by reusing the existing .phony target. Olaf --- a/Config.mk +++ b/Config.mk @@ -167,6 +167,9 @@ define move-if-changed if ! cmp -s $(1) $(2); then mv -f $(1) $(2); else rm -f $(1); fi endef +.PHONY: FORCE +FORCE: + buildmakevars2file = $(eval $(call buildmakevars2file-closure,$(1))) define buildmakevars2file-closure .PHONY: genpath