* missing dependency to compat/xen.h
@ 2014-09-17 11:01 Olaf Hering
2014-09-17 11:35 ` Jan Beulich
0 siblings, 1 reply; 3+ messages in thread
From: Olaf Hering @ 2014-09-17 11:01 UTC (permalink / raw)
To: xen-devel
Not sure if I messed up my staging tree, or if there is a real dependency bug.
Today it happend two times that my build fails like this:
In file included from /home/olaf/work/github/olafhering/xen/xen/include/xen/sched.h:7:0,
from x86_64/asm-offsets.c:10:
/home/olaf/work/github/olafhering/xen/xen/include/xen/shared.h:6:24: fatal error: compat/xen.h: No such file or directory
#include <compat/xen.h>
^
compilation terminated.
Makefile:150: recipe for target 'asm-offsets.s' failed
make[3]: *** [asm-offsets.s] Error 1
Initially I had make -j8, but another run with '-j1' appended did not fix it for me.
How is compat/xen.h supposed to be created?
My cmdline is 'make -j 8 rpmball debug=n
EXTRA_CFLAGS_XEN_TOOLS=-Wl,-rpath,/opt/xen/staging-upstream/lib/xen/lib
APPEND_LDFLAGS=-Wl,-rpath,/opt/xen/staging-upstream/lib/xen/lib
BOOT_DIR=/opt/xen/staging-upstream/boot
CONFIG_DIR=/opt/xen/staging-upstream/etc
INITD_DIR=/opt/xen/staging-upstream/etc/init.d RPMPKG_SUFFIX=-upstream
XEN_VENDORVERSION=.1410951188'
Olaf
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: missing dependency to compat/xen.h
2014-09-17 11:01 missing dependency to compat/xen.h Olaf Hering
@ 2014-09-17 11:35 ` Jan Beulich
2014-09-19 9:28 ` Olaf Hering
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2014-09-17 11:35 UTC (permalink / raw)
To: Olaf Hering; +Cc: xen-devel
>>> On 17.09.14 at 13:01, <olaf@aepfle.de> wrote:
> Not sure if I messed up my staging tree, or if there is a real dependency
> bug.
> Today it happend two times that my build fails like this:
>
> In file included from
> /home/olaf/work/github/olafhering/xen/xen/include/xen/sched.h:7:0,
> from x86_64/asm-offsets.c:10:
> /home/olaf/work/github/olafhering/xen/xen/include/xen/shared.h:6:24: fatal
> error: compat/xen.h: No such file or directory
> #include <compat/xen.h>
> ^
> compilation terminated.
> Makefile:150: recipe for target 'asm-offsets.s' failed
> make[3]: *** [asm-offsets.s] Error 1
>
> Initially I had make -j8, but another run with '-j1' appended did not fix it
> for me.
> How is compat/xen.h supposed to be created?
This make rule
$(TARGET): delete-unfresh-files
$(MAKE) -C tools
$(MAKE) -f $(BASEDIR)/Rules.mk include/xen/compile.h
[ -e include/asm ] || ln -sf asm-$(TARGET_ARCH) include/asm
$(MAKE) -f $(BASEDIR)/Rules.mk -C include
$(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) asm-offsets.s
$(MAKE) -f $(BASEDIR)/Rules.mk include/asm-$(TARGET_ARCH)/asm-offsets.h
$(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $(TARGET)
is - afaict - guaranteeing that the include/compat/ generation
happens before that of asm-offsets.s.
Jan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: missing dependency to compat/xen.h
2014-09-17 11:35 ` Jan Beulich
@ 2014-09-19 9:28 ` Olaf Hering
0 siblings, 0 replies; 3+ messages in thread
From: Olaf Hering @ 2014-09-19 9:28 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel
On Wed, Sep 17, Jan Beulich wrote:
> >>> On 17.09.14 at 13:01, <olaf@aepfle.de> wrote:
> > How is compat/xen.h supposed to be created?
> This make rule
>
> $(TARGET): delete-unfresh-files
> $(MAKE) -C tools
> $(MAKE) -f $(BASEDIR)/Rules.mk include/xen/compile.h
> [ -e include/asm ] || ln -sf asm-$(TARGET_ARCH) include/asm
> $(MAKE) -f $(BASEDIR)/Rules.mk -C include
> $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) asm-offsets.s
> $(MAKE) -f $(BASEDIR)/Rules.mk include/asm-$(TARGET_ARCH)/asm-offsets.h
> $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $(TARGET)
>
> is - afaict - guaranteeing that the include/compat/ generation
> happens before that of asm-offsets.s.
I had a change like shown below, which confused the xen build. Meanwhile
I found a way to achive my goal without such a change by reusing the
existing .phony target.
Olaf
--- a/Config.mk
+++ b/Config.mk
@@ -167,6 +167,9 @@ define move-if-changed
if ! cmp -s $(1) $(2); then mv -f $(1) $(2); else rm -f $(1); fi
endef
+.PHONY: FORCE
+FORCE:
+
buildmakevars2file = $(eval $(call buildmakevars2file-closure,$(1)))
define buildmakevars2file-closure
.PHONY: genpath
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-19 9:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-17 11:01 missing dependency to compat/xen.h Olaf Hering
2014-09-17 11:35 ` Jan Beulich
2014-09-19 9:28 ` Olaf Hering
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).