From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH 32/46] Add configure
 --with-linux-backend-modules="mod1 mod2"
Date: Tue, 23 Sep 2014 12:36:45 +0200
Message-ID: <20140923103645.GA622@aepfle.de>
References: <1411390835-7348-1-git-send-email-olaf@aepfle.de>
	<1411390835-7348-33-git-send-email-olaf@aepfle.de>
	<1411468138.14989.64.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1411468138.14989.64.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Keir Fraser <keir@xen.org>, David Scott <dave.scott@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>, Samuel Thibault <samuel.thibault@ens-lyon.org>
List-Id: xen-devel@lists.xenproject.org

On Tue, Sep 23, Ian Campbell wrote:

> On Mon, 2014-09-22 at 15:00 +0200, Olaf Hering wrote:
> > This replaces config/Linux.modules with a configure option. As a result
> > of this change only a single xencomons.in is required, instead of a
> > xencomons.in.in and sed hackery.
> 
> I think the change wrt which blktap modules are loaded deserves
> mentioning here, since it is a functional change. It's almost worth
> making that trivial sounding change separately, in case there are
> knockon effects.

At least systemd would load blktap2 and blktap via xen.conf. And the
SUSE xencommons also loads both drivers. So I think they can coexist.
No sure what the intent of the initial "modprobe blktap2 || modprobe
blktap" was. I think doing it that way did not solve a real bug. The
comments in the discussion at that time did not provide a hint that a
bug was fixed.

Olaf