From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH 03/46] install.sh: Preserve permissions from
	make install
Date: Tue, 23 Sep 2014 14:14:38 +0200
Message-ID: <20140923121438.GA10033@aepfle.de>
References: <1411390835-7348-1-git-send-email-olaf@aepfle.de>
	<1411390835-7348-4-git-send-email-olaf@aepfle.de>
	<1411401257.26552.18.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1411401257.26552.18.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Keir Fraser <keir@xen.org>, David Scott <dave.scott@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>, Samuel Thibault <samuel.thibault@ens-lyon.org>
List-Id: xen-devel@lists.xenproject.org

On Mon, Sep 22, Ian Campbell wrote:

> On Mon, 2014-09-22 at 14:59 +0200, Olaf Hering wrote:
> Although, do you suppose that the tar unpack right above it ought to use
> -p/--preserve-permissions ?

At least the tar I use preserves permissions automatically.
I wonder what the removed chmod tried to fix anyway.

Olaf

> > +++ b/install.sh
> > @@ -27,9 +27,6 @@ tmp="`mktemp -d`"
> >  echo "Installing Xen from '$src' to '$dst'..."
> >  (cd $src; tar -cf - * ) | tar -C "$tmp" -xf -
> >  
> > -echo " - modifying permissions"
> > -chmod -R a+rX "$tmp"
> > -
> >  (cd $tmp; tar -cf - *) | tar --no-same-owner -C "$dst" -xf -
> >  rm -rf "$tmp"
> >  
> 
>