xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: David Scott <dave.scott@citrix.com>
Cc: xen-devel@lists.xenproject.org, ian.campbell@citrix.com,
	ian.jackson@eu.citrix.com, wei.liu2@citrix.com,
	stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v6 for-4.5 1/5] libxl: add support for 'channels'
Date: Fri, 26 Sep 2014 10:12:50 +0100	[thread overview]
Message-ID: <20140926091250.GA12753@zion.uk.xensource.com> (raw)
In-Reply-To: <1411591685-25308-2-git-send-email-dave.scott@citrix.com>

In general this looks good to me.

Ian Jackson asked one question which remained unanswered in the last
iteration.

QUOTE
There are also unfortunate security implications to reading the
backend directory like that - if we have a driver domain, the qemu
might get untrustworthy paths.
ENDQUOTE

Has that question become moot? Did I miss anything?

Wei.

  parent reply	other threads:[~2014-09-26  9:12 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24 20:48 xl, libxl: add support for 'channels' David Scott
2014-09-24 20:48 ` [PATCH v6 for-4.5 1/5] " David Scott
2014-09-25 18:56   ` Konrad Rzeszutek Wilk
2014-09-26  9:12   ` Wei Liu [this message]
2014-09-24 20:48 ` [PATCH v6 for-4.5 2/5] xl: move 'replace_string' further up the file David Scott
2014-09-25 19:06   ` Konrad Rzeszutek Wilk
2014-09-26  9:15   ` Wei Liu
2014-09-24 20:48 ` [PATCH v6 for-4.5 3/5] xl: add 'xstrdup' next to 'xrealloc' David Scott
2014-09-25 19:06   ` Konrad Rzeszutek Wilk
2014-09-26  9:22   ` Wei Liu
2014-09-24 20:48 ` [PATCH v6 for-4.5 4/5] xl: add 'trim' and 'split_string_into_pair' functions David Scott
2014-09-25 19:06   ` Konrad Rzeszutek Wilk
2014-09-26 10:09   ` Wei Liu
2014-09-26 15:45     ` Ian Jackson
2014-09-26 15:51       ` Wei Liu
2014-09-26 15:53         ` Ian Jackson
2014-09-24 20:48 ` [PATCH v6 for-4.5 5/5] xl: add support for 'channels' David Scott
2014-09-25 19:11   ` Konrad Rzeszutek Wilk
2014-09-26 10:22   ` Wei Liu
2014-09-25 19:13 ` xl, libxl: " Konrad Rzeszutek Wilk
2014-09-25 19:37   ` Dave Scott
2014-09-26 15:14     ` Ian Jackson
2014-09-26 19:20       ` Konrad Rzeszutek Wilk
2014-10-07 16:52         ` Dave Scott
2014-10-07 16:59           ` Konrad Rzeszutek Wilk
2014-10-08 11:06           ` Stefano Stabellini
2014-10-08 13:26           ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140926091250.GA12753@zion.uk.xensource.com \
    --to=wei.liu2@citrix.com \
    --cc=dave.scott@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).