From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH 01/28] Neutralize make uninstall Date: Wed, 1 Oct 2014 07:52:59 +0200 Message-ID: <20141001055259.GA29585@aepfle.de> References: <1411658423-18877-1-git-send-email-olaf@aepfle.de> <1411658423-18877-2-git-send-email-olaf@aepfle.de> <1411998589.3801.20.camel@citrix.com> <20140930120934.GC15029@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20140930120934.GC15029@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Tim Deegan , Keir Fraser , Ian Jackson , Jan Beulich , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, Sep 30, Olaf Hering wrote: > On Mon, Sep 29, Ian Campbell wrote: > > Yet? Will this be replaced by additions to the appropriate submake files > > in the course of this series? > No. Unless I miss something, make uninstall can not work today. At least > for the toplevel Makefile. If you want I can add more uninstall parts to > the tools Makefiles in a separate series. Either for 4.5 or later. Ian, now that I look at staging-4.4 I see that the toplevel Makefile includes config/StdGNU.mk which sets path variables used by the uninstall target. So my series broke uninstall because the variables are not available anymore during 'make uninstall'. I think the right fix is to move the uninstall target to the invividual Makefiles in tools/hotplug/. XEN_RUN_DIR is created at runtime now, it should be left alone by uninstall. /var/lib/xen is created in tools/Makefile, so it should be removed there. I will adjust this patch and include it in v5 of this series. Olaf