xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: keir@xen.org, Ian.Campbell@citrix.com,
	stefano.stabellini@eu.citrix.com, George.Dunlap@eu.citrix.com,
	andrew.cooper3@citrix.com, Ian.Jackson@eu.citrix.com,
	xen-devel@lists.xen.org, Chao Peng <chao.p.peng@linux.intel.com>,
	dgdegra@tycho.nsa.gov
Subject: Re: [PATCH v19 00/10] enable Cache Monitoring Technology (CMT) feature
Date: Thu, 2 Oct 2014 16:07:47 -0400	[thread overview]
Message-ID: <20141002200747.GA9217@laptop.dumpdata.com> (raw)
In-Reply-To: <542D7E6E020000780003C0BD@mail.emea.novell.com>

On Thu, Oct 02, 2014 at 03:33:50PM +0100, Jan Beulich wrote:
> >>> On 02.10.14 at 13:35, <chao.p.peng@linux.intel.com> wrote:
> > Chao Peng (10):
> >   x86: add generic resource (e.g. MSR) access hypercall
> >   xsm: add resource operation related xsm policy
> >   tools: provide interface for generic resource access
> >   x86: detect and initialize Cache Monitoring Technology feature
> >   x86: dynamically attach/detach CMT service for a guest
> >   x86: collect global CMT information
> >   x86: enable CMT for each domain RMID
> >   x86: add CMT related MSRs in allowed list
> >   xsm: add CMT related xsm policies
> >   tools: CMDs and APIs for Cache Monitoring Technology
> 
> So apart from patch 10 this series can now be considered
> sufficiently acked to go in. Which means - Konrad, you'll now have
> to decide whether it still should (possibly including whether to wait
> for patch 10 to get acked).

I believe it is OK to add this in as:

 - It is a new functionality that will only be used if the system admin
   uses the bootup parameters. Hence existing users / use-cases will not be affected.

 - The common code that is used to "glue" the CMT with this is quite simple.

 - The two new sets of hypercalls are safe and look to not cause DoS nor inflict
   damage to the hypervisor. They also have XSM labels.

 - The risk of regression in normal existing use-case is minimal.

I am OK with patch #10 going in after getting an Ack/Reviewed-by from
one of the tools maintainers. Since that is not right now happening it can
be done later (but before RC0). Or if it misses RC0 then it would have to be
done in Xen 4.6.

So Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> all patches
except #10.

> 
> Jan
> 

      reply	other threads:[~2014-10-02 20:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02 11:35 [PATCH v19 00/10] enable Cache Monitoring Technology (CMT) feature Chao Peng
2014-10-02 11:35 ` [PATCH v19 01/10] x86: add generic resource (e.g. MSR) access hypercall Chao Peng
2014-10-02 14:22   ` Jan Beulich
2014-10-02 11:35 ` [PATCH v19 02/10] xsm: add resource operation related xsm policy Chao Peng
2014-10-02 11:35 ` [PATCH v19 03/10] tools: provide interface for generic resource access Chao Peng
2014-10-02 11:35 ` [PATCH v19 04/10] x86: detect and initialize Cache Monitoring Technology feature Chao Peng
2014-10-02 14:29   ` Jan Beulich
2014-10-02 11:35 ` [PATCH v19 05/10] x86: dynamically attach/detach CMT service for a guest Chao Peng
2014-10-02 11:35 ` [PATCH v19 06/10] x86: collect global CMT information Chao Peng
2014-10-02 11:35 ` [PATCH v19 07/10] x86: enable CMT for each domain RMID Chao Peng
2014-10-02 11:35 ` [PATCH v19 08/10] x86: add CMT related MSRs in allowed list Chao Peng
2014-10-02 11:35 ` [PATCH v19 09/10] xsm: add CMT related xsm policies Chao Peng
2014-10-02 11:35 ` [PATCH v19 10/10] tools: CMDs and APIs for Cache Monitoring Technology Chao Peng
2014-10-02 14:33 ` [PATCH v19 00/10] enable Cache Monitoring Technology (CMT) feature Jan Beulich
2014-10-02 20:07   ` Konrad Rzeszutek Wilk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141002200747.GA9217@laptop.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=chao.p.peng@linux.intel.com \
    --cc=dgdegra@tycho.nsa.gov \
    --cc=keir@xen.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).