xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH 00/28 v5 for-xen-4.5] tool changes to honor configure --prefix=DIR
Date: Mon, 6 Oct 2014 10:05:37 -0400	[thread overview]
Message-ID: <20141006140537.GC4473@laptop.dumpdata.com> (raw)
In-Reply-To: <1412181690-19609-1-git-send-email-olaf@aepfle.de>

On Wed, Oct 01, 2014 at 06:41:02PM +0200, Olaf Hering wrote:
> Konrad, you are in CC because I would like to see this in 4.5-rc1.

Thank you.
> 
> 
> In my attempt to get a xen.rpm from 'make rpmball' which operates
> entirely below the configured --prefix= I came up with these changes.

Released-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Regression wise it will be quite easy to figure out if something is broken -
it hasn't been built. Hence the error reporting of that should be fairly easy.

The benefit of this change is that it does an good cleanup of
Makefile/configure.ac and in the long term that should make it better
and easier to compile Xen on other platforms.

> 
> This is a resend of the remaining parts of this series with the
> comments incorporated:
> http://lists.xenproject.org/archives/html/xen-devel/2014-09/msg03003.html
> http://lists.xenproject.org/archives/html/xen-devel/2014-09/msg03981.html
> 
> In v5 of this series the --libexec patch was updated to also remove
> PRIVATE_PREFIX and PRIVATE_BINDIR from paths.m4, and it does not remove
> $(LIBDIR)/xen/ anymore - just $(LIBEXEC). The patch to "separate runtime
> debug info" is the simplified version.
> 
> 
> With this series its now possible to run everything except pygrub
> below the configured --prefix=.

Yeey!
> 
> NOTE: the renaming of tools/hotplug/Linux/init.d/xencommons.in may
> cause trouble in configured working copies. Use 'git clean -dfx' to
> wipe all and everything before git pull.
> 
> One outstanding bug is pygrub, which does not know about
> $prefix/$lib/python/site-packages. This is still on my todo list.
> 
> Please rerun autogen.sh after applying this series.
> 
> Olaf
> 
> 
> 
> Olaf Hering (28):
>   tools: fix make uninstall
>   tools/hotplug: fix race during xen.conf creation
>   tools/python: use also LDFLAGS for build
>   Add configure --with-initddir=DIR
>   tools/hotplug: use XEN_SCRIPT_DIR instead of hardcoded path
>   tools/configure.ac: sort AC_CONFIG_FILES
>   tools/hotplug: use INITD_DIR instead of CONFIG_DIR/init.d|rc.d
>   tools/hotplug: substitute XEN_SCRIPT_DIR on FreeBSD
>   remove duplicate variables from config
>   Substitue configure variables in Paths.mk.in
>   tools: substitute bindir instead of BINDIR
>   Use configure --mandir=DIR to set MANDIR
>   Use configure --docdir=DIR to set DOCDIR
>   Use configure --includedir=DIR to set INCLUDEDIR
>   Use configure --libexecdir=BASEDIR to set LIBEXEC
>   Use configure --prefix=DIR to set PREFIX
>   Use configure --localstatedir=BASEDIR to set path to /var
>   Add configure --enable-rpath
>   Add configure --with-linux-backend-modules="mod1 mod2"
>   Move variable to set bash_completion.d to Paths.mk
>   Add configure --with-sysconfig-leaf-dir=SUBDIR to set CONFIG_LEAF_DIR
>   Make XENFIRMWAREDIR a subdir of libexecdir
>   tools: remove private copies of includedir and libdir from libxenstat
>   Use Paths.mk for docs, stubdom and tools build
>   tools: use XEN_LIB_STORED instead of /var/lib/xenstored
>   tools/hotplug: Use XEN_RUN_DIR instead of /var/run/xen
>   move vtpmmgr helpers from tools to stubdom
>   Separate runtime debug output from debug symbols
> 
>  .gitignore                                         |   7 ++
>  Config.mk                                          |  14 +--
>  Makefile                                           |  12 ---
>  README                                             |  12 ---
>  config/Docs.mk.in                                  |   7 +-
>  config/Linux.mk                                    |   2 +
>  config/Linux.modules                               |  20 ----
>  config/NetBSD.mk                                   |   5 -
>  config/NetBSDRump.mk                               |   2 -
>  config/Paths.mk.in                                 |  44 +++++++--
>  config/StdGNU.mk                                   |  23 -----
>  config/Stubdom.mk.in                               |   7 --
>  config/SunOS.mk                                    |  15 ---
>  config/Tools.mk.in                                 |  13 +--
>  docs/misc/distro_mapping.txt                       |   5 +-
>  m4/paths.m4                                        | 101 ++++++++++++++-------
>  m4/xenstored.m4                                    |   8 +-
>  stubdom/Makefile                                   |   9 +-
>  stubdom/vtpmmgr/Makefile                           |   5 +
>  {tools => stubdom}/vtpmmgr/calc.pl                 |   0
>  {tools => stubdom}/vtpmmgr/manage-vtpmmgr.pl       |   0
>  tools/Makefile                                     |  46 ++++++++--
>  tools/Rules.mk                                     |   1 -
>  tools/configure.ac                                 |  53 +++++++++--
>  tools/console/Makefile                             |   4 +-
>  tools/hotplug/FreeBSD/Makefile                     |   5 +-
>  .../FreeBSD/rc.d/{xencommons => xencommons.in}     |   6 +-
>  tools/hotplug/FreeBSD/vif-bridge                   |   2 +-
>  tools/hotplug/Linux/Makefile                       |  18 ++--
>  tools/hotplug/Linux/init.d/sysconfig.xencommons.in |  10 +-
>  .../Linux/init.d/{xen-watchdog => xen-watchdog.in} |   2 +-
>  .../init.d/{xencommons.in.in => xencommons.in}     |  13 ++-
>  .../Linux/init.d/{xendomains => xendomains.in}     |  14 +--
>  tools/hotplug/Linux/systemd/Makefile               |  37 ++------
>  .../systemd/xen-qemu-dom0-disk-backend.service.in  |   4 +-
>  .../hotplug/Linux/systemd/xen-watchdog.service.in  |   2 +-
>  tools/hotplug/Linux/systemd/xenconsoled.service.in |   2 +-
>  tools/hotplug/Linux/systemd/xendomains.service.in  |   6 +-
>  tools/hotplug/Linux/systemd/xenstored.service.in   |   4 +-
>  tools/hotplug/Linux/update-modules.sh              |  36 --------
>  tools/hotplug/Linux/{vif-setup => vif-setup.in}    |   2 +-
>  .../{xen-backend.rules => xen-backend.rules.in}    |  16 ++--
>  ...-hotplug-common.sh => xen-hotplug-common.sh.in} |   4 +-
>  tools/hotplug/Linux/{xendomains => xendomains.in}  |   2 +-
>  tools/hotplug/NetBSD/Makefile                      |   6 +-
>  tools/hotplug/NetBSD/block                         |   2 +-
>  .../NetBSD/rc.d/{xencommons => xencommons.in}      |   4 +-
>  tools/hotplug/NetBSD/vif-bridge                    |   2 +-
>  tools/hotplug/NetBSD/vif-ip                        |   2 +-
>  tools/libxl/Makefile                               |   6 +-
>  tools/libxl/libxl_dm.c                             |   4 +-
>  tools/libxl/libxl_internal.h                       |   1 -
>  tools/libxl/libxl_paths.c                          |   7 +-
>  tools/libxl/libxl_save_callout.c                   |   2 +-
>  tools/misc/Makefile                                |   4 +-
>  tools/ocaml/common.make                            |   5 +-
>  tools/pygrub/Makefile                              |   8 +-
>  tools/python/Makefile                              |   4 +-
>  tools/vtpmmgr/Makefile                             |  15 ---
>  tools/xcutils/Makefile                             |   4 +-
>  tools/xenpaging/Makefile                           |   4 +-
>  tools/xenstat/libxenstat/Makefile                  |   4 -
>  tools/xenstore/Makefile                            |   3 +-
>  tools/xenstore/xs_lib.c                            |   2 +-
>  tools/xentrace/Makefile                            |   4 +-
>  xen/Rules.mk                                       |   3 +-
>  66 files changed, 322 insertions(+), 374 deletions(-)
>  delete mode 100644 config/Linux.modules
>  rename {tools => stubdom}/vtpmmgr/calc.pl (100%)
>  rename {tools => stubdom}/vtpmmgr/manage-vtpmmgr.pl (100%)
>  rename tools/hotplug/FreeBSD/rc.d/{xencommons => xencommons.in} (96%)
>  rename tools/hotplug/Linux/init.d/{xen-watchdog => xen-watchdog.in} (97%)
>  rename tools/hotplug/Linux/init.d/{xencommons.in.in => xencommons.in} (91%)
>  rename tools/hotplug/Linux/init.d/{xendomains => xendomains.in} (79%)
>  delete mode 100755 tools/hotplug/Linux/update-modules.sh
>  rename tools/hotplug/Linux/{vif-setup => vif-setup.in} (61%)
>  rename tools/hotplug/Linux/{xen-backend.rules => xen-backend.rules.in} (62%)
>  rename tools/hotplug/Linux/{xen-hotplug-common.sh => xen-hotplug-common.sh.in} (94%)
>  rename tools/hotplug/Linux/{xendomains => xendomains.in} (99%)
>  rename tools/hotplug/NetBSD/rc.d/{xencommons => xencommons.in} (97%)
>  delete mode 100644 tools/vtpmmgr/Makefile
> 

  parent reply	other threads:[~2014-10-06 14:05 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-01 16:41 [PATCH 00/28 v5 for-xen-4.5] tool changes to honor configure --prefix=DIR Olaf Hering
2014-10-01 16:41 ` [PATCH 01/28] tools: fix make uninstall Olaf Hering
2014-10-02 14:11   ` Ian Campbell
2014-10-01 16:41 ` [PATCH 02/28] tools/hotplug: fix race during xen.conf creation Olaf Hering
2014-10-06 13:48   ` Konrad Rzeszutek Wilk
2014-10-01 16:41 ` [PATCH 03/28] tools/python: use also LDFLAGS for build Olaf Hering
2014-10-01 16:41 ` [PATCH 04/28] Add configure --with-initddir=DIR Olaf Hering
2014-10-01 16:41 ` [PATCH 05/28] tools/hotplug: use XEN_SCRIPT_DIR instead of hardcoded path Olaf Hering
2014-10-01 16:41 ` [PATCH 06/28] tools/configure.ac: sort AC_CONFIG_FILES Olaf Hering
2014-10-01 16:41 ` [PATCH 07/28] tools/hotplug: use INITD_DIR instead of CONFIG_DIR/init.d|rc.d Olaf Hering
2014-10-01 16:41 ` [PATCH 08/28] tools/hotplug: substitute XEN_SCRIPT_DIR on FreeBSD Olaf Hering
2014-10-01 16:41 ` [PATCH 09/28] remove duplicate variables from config Olaf Hering
2014-10-01 16:41 ` [PATCH 10/28] Substitue configure variables in Paths.mk.in Olaf Hering
2014-10-01 16:41 ` [PATCH 11/28] tools: substitute bindir instead of BINDIR Olaf Hering
2014-10-01 16:41 ` [PATCH 12/28] Use configure --mandir=DIR to set MANDIR Olaf Hering
2014-10-01 16:41 ` [PATCH 13/28] Use configure --docdir=DIR to set DOCDIR Olaf Hering
2014-10-01 16:41 ` [PATCH 14/28] Use configure --includedir=DIR to set INCLUDEDIR Olaf Hering
2014-10-01 16:41 ` [PATCH 15/28] Use configure --libexecdir=BASEDIR to set LIBEXEC Olaf Hering
2014-10-06 15:40   ` Ian Campbell
2014-10-06 15:53     ` [PATCH] QEMU_TAG update FOR FOLDING INTO LIBEXEC PATCH Ian Jackson
2014-10-07  6:52     ` [PATCH 15/28] Use configure --libexecdir=BASEDIR to set LIBEXEC Olaf Hering
2014-10-01 16:41 ` [PATCH 16/28] Use configure --prefix=DIR to set PREFIX Olaf Hering
2014-10-01 16:41 ` [PATCH 17/28] Use configure --localstatedir=BASEDIR to set path to /var Olaf Hering
2014-10-01 16:41 ` [PATCH 18/28] Add configure --enable-rpath Olaf Hering
2014-10-01 16:41 ` [PATCH 19/28] Add configure --with-linux-backend-modules="mod1 mod2" Olaf Hering
2014-10-01 16:41 ` [PATCH 20/28] Move variable to set bash_completion.d to Paths.mk Olaf Hering
2014-10-01 16:41 ` [PATCH 21/28] Add configure --with-sysconfig-leaf-dir=SUBDIR to set CONFIG_LEAF_DIR Olaf Hering
2014-10-01 16:41 ` [PATCH 22/28] Make XENFIRMWAREDIR a subdir of libexecdir Olaf Hering
2014-10-01 16:41 ` [PATCH 23/28] tools: remove private copies of includedir and libdir from libxenstat Olaf Hering
2014-10-01 16:41 ` [PATCH 24/28] Use Paths.mk for docs, stubdom and tools build Olaf Hering
2014-10-01 16:41 ` [PATCH 25/28] tools: use XEN_LIB_STORED instead of /var/lib/xenstored Olaf Hering
2014-10-01 16:41 ` [PATCH 26/28] tools/hotplug: Use XEN_RUN_DIR instead of /var/run/xen Olaf Hering
2014-10-01 16:41 ` [PATCH 27/28] move vtpmmgr helpers from tools to stubdom Olaf Hering
2014-10-01 21:51   ` Daniel De Graaf
2014-10-01 16:41 ` [PATCH 28/28] Separate runtime debug output from debug symbols Olaf Hering
2014-10-02  7:26   ` Jan Beulich
2014-10-02  8:00     ` Olaf Hering
2014-10-02  8:06       ` Jan Beulich
2014-10-02  9:52         ` Tim Deegan
2014-10-02 10:27           ` Jan Beulich
2014-10-02 16:52             ` Andrew Cooper
2014-10-06  7:31               ` Jan Beulich
2014-10-06  7:40                 ` Olaf Hering
2014-10-02 10:45         ` Olaf Hering
2014-10-02 14:15   ` Ian Campbell
2014-10-06  8:55   ` [PATCH v2] " Olaf Hering
2014-10-06  9:03     ` Jan Beulich
2014-10-08 12:45       ` Ian Campbell
2014-10-08 12:55         ` Olaf Hering
2014-10-08 13:18           ` Olaf Hering
2014-10-06 14:05 ` Konrad Rzeszutek Wilk [this message]
2014-10-06 16:32 ` [PATCH 00/28 v5 for-xen-4.5] tool changes to honor configure --prefix=DIR Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141006140537.GC4473@laptop.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=olaf@aepfle.de \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).