From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Julien Grall <julien.grall@linaro.org>
Cc: Thomas Leonard <talex5@gmail.com>,
Dave.Scott@eu.citrix.com, anil@recoil.org,
stefano.stabellini@eu.citrix.com, xen-devel@lists.xenproject.org,
Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH ARM v8 2/4] mini-os: arm: interrupt controller
Date: Wed, 22 Oct 2014 15:14:49 +0200 [thread overview]
Message-ID: <20141022131449.GL3659@type.bordeaux.inria.fr> (raw)
In-Reply-To: <5447ABE4.1030703@linaro.org>
Julien Grall, le Wed 22 Oct 2014 14:06:44 +0100, a écrit :
> >>>> + return value;
> >>>> +}
> >>>> +
> >>>> +static inline void REG_WRITE32(volatile uint32_t *addr, unsigned int value)
> >>>> +{
> >>>> + __asm__ __volatile__("str %0, [%1]"::"r"(value), "r"(addr));
> >>>> + wmb();
> >>>> +}
>
> write barrier may be necessary on some, where we need to wait that all
> write has been done before doing this one (such as enable the GIC ...).
>
> So this function is buggy. It should be:
>
> wmb();
> __asm__ __volatile__(....).
Well, I'd say it's the caller of REG_WRITE32 which should explicit it.
Samuel
next prev parent reply other threads:[~2014-10-22 13:14 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 9:20 [PATCH ARM v8 0/4] mini-os: initial ARM support Thomas Leonard
2014-10-03 9:20 ` [PATCH ARM v8 1/4] mini-os: arm: time Thomas Leonard
2014-10-21 10:50 ` Ian Campbell
2014-10-21 14:07 ` [PATCH incomplete] xen: arm: wallclock support (incomplete, needs work/refactoring) Ian Campbell
2014-10-26 9:51 ` [PATCH ARM v8 1/4] mini-os: arm: time Thomas Leonard
2014-10-27 10:34 ` Ian Campbell
2014-11-13 16:29 ` Thomas Leonard
2014-11-14 10:29 ` Ian Campbell
2014-11-19 20:57 ` Konrad Rzeszutek Wilk
2015-01-08 15:52 ` Ian Campbell
2015-01-08 15:58 ` Thomas Leonard
2015-01-08 16:04 ` Ian Campbell
2014-10-03 9:20 ` [PATCH ARM v8 2/4] mini-os: arm: interrupt controller Thomas Leonard
2014-10-21 11:00 ` Ian Campbell
2014-10-21 14:26 ` Julien Grall
2014-10-21 15:16 ` Ian Campbell
2014-10-21 15:22 ` Julien Grall
2014-10-21 15:35 ` Ian Campbell
2014-10-21 16:03 ` Julien Grall
2014-10-21 18:14 ` Anil Madhavapeddy
2014-10-21 19:18 ` Ian Campbell
2014-10-21 21:54 ` Samuel Thibault
2014-10-22 9:03 ` Ian Campbell
2014-10-22 13:06 ` Julien Grall
2014-10-22 13:14 ` Samuel Thibault [this message]
2014-10-28 15:15 ` Thomas Leonard
2014-10-28 15:25 ` Julien Grall
2014-10-28 15:43 ` Thomas Leonard
2014-10-28 15:51 ` Julien Grall
2014-11-14 10:22 ` Thomas Leonard
2014-11-14 11:33 ` Julien Grall
2014-11-14 11:42 ` Ian Campbell
2014-11-14 11:48 ` Julien Grall
2014-11-14 12:01 ` Ian Campbell
2014-10-03 9:20 ` [PATCH ARM v8 3/4] mini-os: arm: build system Thomas Leonard
2014-10-21 11:44 ` Ian Campbell
2014-10-21 21:50 ` Samuel Thibault
2014-10-22 9:01 ` Ian Campbell
2014-10-22 9:59 ` Samuel Thibault
2014-10-26 9:46 ` Thomas Leonard
2014-10-26 9:55 ` Samuel Thibault
2014-10-26 10:25 ` Thomas Leonard
2014-11-17 11:42 ` Thomas Leonard
2014-11-17 11:45 ` Ian Campbell
2014-11-17 11:47 ` Andrew Cooper
2014-11-17 11:47 ` Samuel Thibault
2014-10-03 9:20 ` [PATCH ARM v8 4/4] mini-os: arm: show registers, stack and exception vector on fault Thomas Leonard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141022131449.GL3659@type.bordeaux.inria.fr \
--to=samuel.thibault@ens-lyon.org \
--cc=Dave.Scott@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=anil@recoil.org \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=talex5@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).