From: Olaf Hering <olaf@aepfle.de>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH for-4.5] tools/pygrub: Fix TOCTOU race introduced by c/s 63dcc68
Date: Wed, 29 Oct 2014 17:03:22 +0100 [thread overview]
Message-ID: <20141029160322.GA22428@aepfle.de> (raw)
In-Reply-To: <1414591781-19376-1-git-send-email-andrew.cooper3@citrix.com>
On Wed, Oct 29, Andrew Cooper wrote:
> In addition, use os.makedirs() which will also create intermediate directories
> if they don't exist.
Can this happen in practice, given that /var/run/xen is created by the
runlevel scripts already? The mkdir is now really just @XEN_RUN_DIR@/pygrub.
Olaf
next prev parent reply other threads:[~2014-10-29 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 14:09 [PATCH for-4.5] tools/pygrub: Fix TOCTOU race introduced by c/s 63dcc68 Andrew Cooper
2014-10-29 16:03 ` Olaf Hering [this message]
2014-10-29 18:09 ` Andrew Cooper
2014-10-29 19:43 ` Olaf Hering
2014-11-04 10:48 ` Ian Campbell
2014-11-04 10:52 ` Please *justify* your use of the for-4.5 tag when posting patches Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141029160322.GA22428@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).