Re: [PATCH 5/7] tools/hotplug: use XENCONSOLED_TRACE in xenconsoled.service

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Tue, Jan 06, 2015 at 11:30:38AM +0000, Ian Campbell wrote:
> On Fri, 2014-12-19 at 12:25 +0100, Olaf Hering wrote:
> > Instead of inventing a new XENCONSOLED_LOG= variable reuse the
> > existing XENCONSOLED_TRACE= variable in xenconsoled.service.
> > 
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> (should XENCONSOLED_LOG_DIR be changed for consistency?)

To XENCONSOLED_TRACE_DIR ? It could but lets leave that for
another patch.

> 
> > Cc: Wei Liu <wei.liu2@citrix.com>
> > ---
> >  tools/hotplug/Linux/systemd/xenconsoled.service.in | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/hotplug/Linux/systemd/xenconsoled.service.in b/tools/hotplug/Linux/systemd/xenconsoled.service.in
> > index 74d0428..4788129 100644
> > --- a/tools/hotplug/Linux/systemd/xenconsoled.service.in
> > +++ b/tools/hotplug/Linux/systemd/xenconsoled.service.in
> > @@ -7,13 +7,13 @@ ConditionPathExists=/proc/xen/capabilities
> >  [Service]
> >  Type=simple
> >  Environment=XENCONSOLED_ARGS=
> > -Environment=XENCONSOLED_LOG=none
> > +Environment=XENCONSOLED_TRACE=none
> >  Environment=XENCONSOLED_LOG_DIR=@XEN_LOG_DIR@/console
> >  EnvironmentFile=@CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons
> >  PIDFile=@XEN_RUN_DIR@/xenconsoled.pid
> >  ExecStartPre=/bin/grep -q control_d /proc/xen/capabilities
> >  ExecStartPre=/bin/mkdir -p ${XENCONSOLED_LOG_DIR}
> > -ExecStart=@sbindir@/xenconsoled --pid-file @XEN_RUN_DIR@/xenconsoled.pid --log=${XENCONSOLED_LOG} --log-dir=${XENCONSOLED_LOG_DIR} $XENCONSOLED_ARGS
> > +ExecStart=@sbindir@/xenconsoled --pid-file @XEN_RUN_DIR@/xenconsoled.pid --log=${XENCONSOLED_TRACE} --log-dir=${XENCONSOLED_LOG_DIR} $XENCONSOLED_ARGS
> >  
> >  [Install]
> >  WantedBy=multi-user.target
> 
>