From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Konrad Rzeszutek Wilk <konrad@darnok.org>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 3/3] xentrace: Implement cpu mask range parsing of human values (-c).
Date: Fri, 15 May 2015 16:17:44 -0400 [thread overview]
Message-ID: <20150515201744.GF23819@l.oracle.com> (raw)
In-Reply-To: <CAFLBxZZLMGUox2PirkwrM0nkb+j=j7y8D-g3Sxs9NjMq2ER+Jg@mail.gmail.com>
. snip..
> Right. Well I think all that is unnecessarily hard to understand,
> primarily because it's organized in a confusing way.
Looking at your implementation it is certainly easier (your way).
>
> Rather than try to nitpick you into doing it the way that seems more
> sensible to me, I've rewritten the patch a bit below. This time I've
> actually done some basic testing with it. What do you think?
I like it! Only one minor comment which is style related:
.. snip..
> + /* Process until we find a range terminator */
> + for(c=*s++; !is_terminator(c); c=*s++)
This is missing spaces.
I've committed it in (with the update) - since you are the maintainer
of xentrace.c and it has your SoB on it I figured you would be OK with
it :-)
If I errnously did it - please revert it and accept my apologies!
prev parent reply other threads:[~2015-05-15 20:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 15:39 [PATCH v3] Support CPU-list parsing in xentrace Konrad Rzeszutek Wilk
2015-03-24 15:39 ` [PATCH v3 1/3] libxl/cpumap: Add xc_cpumap_[setcpu, clearcpu, testcpu] to complement xc_cpumap_alloc Konrad Rzeszutek Wilk
2015-03-24 17:46 ` Ian Campbell
2015-03-24 20:29 ` Konrad Rzeszutek Wilk
2015-03-25 8:53 ` Dario Faggioli
2015-03-25 17:16 ` Konrad Rzeszutek Wilk
2015-03-25 8:47 ` Dario Faggioli
2015-03-25 11:01 ` Ian Campbell
2015-03-25 11:16 ` Dario Faggioli
2015-03-24 15:39 ` [PATCH v3 2/3] libxc/xentrace: Replace xc_tbuf_set_cpu_mask with CPU mask with xc_cpumap_t instead of uint32_t Konrad Rzeszutek Wilk
2015-03-30 16:10 ` George Dunlap
2015-03-30 16:54 ` Konrad Rzeszutek Wilk
2015-03-30 17:33 ` George Dunlap
2015-03-30 18:04 ` Konrad Rzeszutek Wilk
2015-03-31 10:41 ` George Dunlap
2015-03-24 15:39 ` [PATCH v3 3/3] xentrace: Implement cpu mask range parsing of human values (-c) Konrad Rzeszutek Wilk
2015-03-31 11:31 ` George Dunlap
2015-04-03 19:34 ` Konrad Rzeszutek Wilk
2015-05-07 16:07 ` George Dunlap
2015-05-15 20:17 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150515201744.GF23819@l.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=konrad@darnok.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).