From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v3 3/3] xentrace: Implement cpu mask range parsing of human values (-c). Date: Fri, 15 May 2015 16:17:44 -0400 Message-ID: <20150515201744.GF23819@l.oracle.com> References: <1427211559-15185-1-git-send-email-konrad.wilk@oracle.com> <1427211559-15185-4-git-send-email-konrad.wilk@oracle.com> <551A8596.8010500@eu.citrix.com> <20150403193445.GB28010@andromeda.dapyr.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YtM4G-0004j5-P2 for xen-devel@lists.xenproject.org; Fri, 15 May 2015 20:18:48 +0000 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: Konrad Rzeszutek Wilk , xen-devel List-Id: xen-devel@lists.xenproject.org . snip.. > Right. Well I think all that is unnecessarily hard to understand, > primarily because it's organized in a confusing way. Looking at your implementation it is certainly easier (your way). > > Rather than try to nitpick you into doing it the way that seems more > sensible to me, I've rewritten the patch a bit below. This time I've > actually done some basic testing with it. What do you think? I like it! Only one minor comment which is style related: .. snip.. > + /* Process until we find a range terminator */ > + for(c=*s++; !is_terminator(c); c=*s++) This is missing spaces. I've committed it in (with the update) - since you are the maintainer of xentrace.c and it has your SoB on it I figured you would be OK with it :-) If I errnously did it - please revert it and accept my apologies!