From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Don Slutz <don.slutz@gmail.com>
Cc: Tim Deegan <tim@xen.org>, Kevin Tian <kevin.tian@intel.com>,
Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Jun Nakajima <jun.nakajima@intel.com>,
Eddie Dong <eddie.dong@intel.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Don Slutz <dslutz@verizon.com>,
xen-devel@lists.xen.org,
George Dunlap <George.Dunlap@eu.citrix.com>,
Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH v12 7/8] Add IOREQ_TYPE_VMWARE_PORT
Date: Tue, 7 Jul 2015 11:02:40 -0400 [thread overview]
Message-ID: <20150707150240.GA23199@l.oracle.com> (raw)
In-Reply-To: <5596A266.8020903@Gmail.com>
> >>diff --git a/xen/include/public/hvm/params.h b/xen/include/public/hvm/params.h
> >>index 7c73089..130eba9 100644
> >>--- a/xen/include/public/hvm/params.h
> >>+++ b/xen/include/public/hvm/params.h
> >>@@ -50,6 +50,8 @@
> >> #define HVM_PARAM_PAE_ENABLED 4
> >> #define HVM_PARAM_IOREQ_PFN 5
> >>+/* Extra vmport PFN. */
> >s/Extra/optional/ ?
>
> I do not think "optional" is good to use here. This PFN is required for
> QEMU (or any other ioreq server) to handle vmport access. If you have a
> better name then "extra", please let me know.
How about just 'VMWare Port PFN' ?
>
> -Don Slutz
>
> >>+#define HVM_PARAM_VMPORT_REGS_PFN 35
> >> #define HVM_PARAM_BUFIOREQ_PFN 6
> >> #define HVM_PARAM_BUFIOREQ_EVTCHN 26
> >>@@ -187,6 +189,6 @@
> >> /* Location of the VM Generation ID in guest physical address space. */
> >> #define HVM_PARAM_VM_GENERATION_ID_ADDR 34
> >>-#define HVM_NR_PARAMS 35
> >>+#define HVM_NR_PARAMS 36
> >> #endif /* __XEN_PUBLIC_HVM_PARAMS_H__ */
> >>--
> >>1.8.3.1
> >>
>
next prev parent reply other threads:[~2015-07-07 15:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-27 23:27 [PATCH v12 0/8] Xen VMware tools support Don Slutz
2015-06-27 23:27 ` [PATCH v12 1/8] tools: Add vga=vmware Don Slutz
2015-07-07 15:54 ` Ian Campbell
2015-06-27 23:27 ` [PATCH v12 2/8] xen: Add support for VMware cpuid leaves Don Slutz
2015-07-01 20:01 ` Konrad Rzeszutek Wilk
2015-07-03 22:03 ` Don Slutz
2015-07-07 15:03 ` Konrad Rzeszutek Wilk
2015-07-28 2:54 ` Don Slutz
2015-07-07 15:56 ` Ian Campbell
2015-06-27 23:27 ` [PATCH v12 3/8] tools: Add vmware_hwver support Don Slutz
2015-07-01 20:14 ` Konrad Rzeszutek Wilk
2015-07-07 15:59 ` Ian Campbell
2015-07-28 2:58 ` Don Slutz
2015-06-27 23:27 ` [PATCH v12 4/8] vmware: Add VMware provided include file Don Slutz
2015-06-27 23:27 ` [PATCH v12 5/8] xen: Add vmware_port support Don Slutz
2015-06-27 23:27 ` [PATCH v12 6/8] tools: " Don Slutz
2015-07-07 16:01 ` Ian Campbell
2015-06-27 23:27 ` [PATCH v12 7/8] Add IOREQ_TYPE_VMWARE_PORT Don Slutz
2015-07-01 20:49 ` Konrad Rzeszutek Wilk
2015-07-03 14:55 ` Don Slutz
2015-07-07 15:02 ` Konrad Rzeszutek Wilk [this message]
2015-07-28 2:59 ` Don Slutz
2015-06-27 23:27 ` [PATCH v12 8/8] Add xentrace to vmware_port Don Slutz
2015-06-29 14:54 ` Andrew Cooper
2015-06-29 16:11 ` Don Slutz
2015-07-10 8:40 ` [PATCH v12 0/8] Xen VMware tools support Jan Beulich
2015-07-10 9:07 ` Wei Liu
2015-07-28 3:18 ` Don Slutz
2015-07-28 14:32 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150707150240.GA23199@l.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=don.slutz@gmail.com \
--cc=dslutz@verizon.com \
--cc=eddie.dong@intel.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).