Re: [PATCH 4/9] libxl: event tests: Improve Makefile doc comment

[Wei Liu <wei.liu2@citrix.com>]

On Thu, Jul 09, 2015 at 06:47:52PM +0100, Ian Jackson wrote:
> Including the explanation of how to run these tests.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>

> ---
>  tools/libxl/Makefile |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> index cc9c152..44a4da7 100644
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -109,7 +109,13 @@ LIBXL_TESTS += timedereg
>  # "outside libxl" file is compiled exactly like a piece of application
>  # code.  They must share information via explicit libxl entrypoints.
>  # Unlike proper parts of libxl, it is permissible for libxl_test_FOO.c
> -# to use private global variables for its state.
> +# to use private global variables for its state.  Note that all the
> +# "inside" parts are compiled into a single test library, so their
> +# symbol names must be unique.
> +#
> +# To run these tests, either use LD_PRELOAD to get libxenlight_test.so
> +# loaded, or rename it to libxenlight.so so it is the target of the
> +# appropriate symlinks.
>  
>  LIBXL_TEST_OBJS += $(foreach t, $(LIBXL_TESTS),libxl_test_$t.o)
>  TEST_PROG_OBJS += $(foreach t, $(LIBXL_TESTS),test_$t.o) test_common.o
> -- 
> 1.7.10.4