From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [Xen-devel] [PATCH v2 2/3] util/grub.d/20_linux_xen.in: Add arm64 support Date: Tue, 14 Jul 2015 11:23:51 -0400 Message-ID: <20150714152351.GD10480@l.oracle.com> References: <=fu.wei@linaro.org> <1436777640-31871-1-git-send-email-fu.wei@linaro.org> <1436777640-31871-3-git-send-email-fu.wei@linaro.org> <20150714065317.36dc83aa@opensuse.site> <1436866888.25044.47.camel@citrix.com> Reply-To: The development of GNU GRUB Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1436866888.25044.47.camel@citrix.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: grub-devel-bounces+gcbgd-grub-devel=m.gmane.org@gnu.org Sender: grub-devel-bounces+gcbgd-grub-devel=m.gmane.org@gnu.org To: Ian Campbell Cc: grub-devel@gnu.org, xen-devel@lists.xensource.com, stefano.stabellini@eu.citrix.com, Andrei Borzenkov , phcoder@gmail.com, linaro-uefi@lists.linaro.org, leif.lindholm@linaro.org, ryan.harkin@linaro.org, jcm@redhat.com, fu.wei@linaro.org List-Id: xen-devel@lists.xenproject.org On Tue, Jul 14, 2015 at 10:41:28AM +0100, Ian Campbell wrote: > On Tue, 2015-07-14 at 06:53 +0300, Andrei Borzenkov wrote: > > > +if [ "x$machine" != xaarch64 ]; then > > > + multiboot_cmd="multiboot" > > > + module_cmd="module" And we should use the grub-file --is-multiboot2 to figure out if the Xen binary can also do that - and use multiboot2 protocol. But that patch I can cobble after this one is done. > > > +else > > > + multiboot_cmd="xen_hypervisor" > > > + module_cmd="xen_module" > > > +fi > > > + > > > > Strictly speaking, this is boot-time decision. As mentioned by > > Vladimir, better would be to provide alias xen_hypervisor and > > xen_module in multiboot for platforms supporting Xen (is MIPS really > > supported?) and use it consistently. > > I had been thinking of this the other way around, e.g. on platforms > which support Xen but not multiboot1 "multiboot" would be added as an > alias for xen_hypervisor. > > However so long as grub-mkconfig (via 20_linux_xen) work for everyone > and that peoples existing hand-crafted x86/multiboot/Xen grub.cfg's > continue to work then I think having the alias go either way would be > fine. > > BTW I had been going to suggest a function at the grub.cfg level which > dispatched to the correct command, but I suppose an actual alias is > better. > > Ian. > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel