From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH v5 09/17] VT-d: Remove pointless casts
Date: Wed, 12 Aug 2015 13:03:27 -0400
Message-ID: <20150812170327.GM17650@l.oracle.com>
References: <1439346938-31824-1-git-send-email-feng.wu@intel.com>
	<1439346938-31824-10-git-send-email-feng.wu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1439346938-31824-10-git-send-email-feng.wu@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Feng Wu <feng.wu@intel.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, Aug 12, 2015 at 10:35:30AM +0800, Feng Wu wrote:
> Remove pointless casts.
> 
> Signed-off-by: Feng Wu <feng.wu@intel.com>

I am not even sure if it needs a review..
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

> ---
> v5:
> - Newly added.
> 
>  xen/drivers/passthrough/vtd/utils.c | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/xen/drivers/passthrough/vtd/utils.c b/xen/drivers/passthrough/vtd/utils.c
> index 44c4ef5..162b764 100644
> --- a/xen/drivers/passthrough/vtd/utils.c
> +++ b/xen/drivers/passthrough/vtd/utils.c
> @@ -234,10 +234,9 @@ static void dump_iommu_info(unsigned char key)
>                      continue;
>                  printk("  %04x:  %x   %x  %04x %08x %02x    %x   %x  %x  %x  %x"
>                      "   %x %x\n", i,
> -                    (u32)p->hi.svt, (u32)p->hi.sq, (u32)p->hi.sid,
> -                    (u32)p->lo.dst, (u32)p->lo.vector, (u32)p->lo.avail,
> -                    (u32)p->lo.dlm, (u32)p->lo.tm, (u32)p->lo.rh,
> -                    (u32)p->lo.dm, (u32)p->lo.fpd, (u32)p->lo.p);
> +                    p->hi.svt, p->hi.sq, p->hi.sid, p->lo.dst, p->lo.vector,
> +                    p->lo.avail, p->lo.dlm, p->lo.tm, p->lo.rh, p->lo.dm,
> +                    p->lo.fpd, p->lo.p);
>                  print_cnt++;
>              }
>              if ( iremap_entries )
> @@ -281,11 +280,10 @@ static void dump_iommu_info(unsigned char key)
>  
>                  printk("   %02x:  %04x   %x    %x   %x   %x   %x    %x"
>                      "    %x     %02x\n", i,
> -                    (u32)remap->index_0_14 | ((u32)remap->index_15 << 15),
> -                    (u32)remap->format, (u32)remap->mask, (u32)remap->trigger,
> -                    (u32)remap->irr, (u32)remap->polarity,
> -                    (u32)remap->delivery_status, (u32)remap->delivery_mode,
> -                    (u32)remap->vector);
> +                    remap->index_0_14 | ((u32)remap->index_15 << 15),
> +                    remap->format, remap->mask, remap->trigger, remap->irr,
> +                    remap->polarity, remap->delivery_status, remap->delivery_mode,
> +                    remap->vector);
>              }
>          }
>      }
> -- 
> 2.1.0
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel