From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH v3 07/11] tmem: Make the uint64_t oid[3] a
 proper structure: tmem_oid
Date: Tue, 1 Sep 2015 12:55:12 -0400
Message-ID: <20150901165512.GA23571@l.oracle.com>
References: <1440788000-32635-1-git-send-email-konrad.wilk@oracle.com>
	<1440788000-32635-8-git-send-email-konrad.wilk@oracle.com>
	<55E458E5020000780009E574@prv-mh.provo.novell.com>
	<20150831153720.GA9931@l.oracle.com>
	<55E4874702000078000D7A72@prv-mh.provo.novell.com>
	<20150831161416.GA7982@l.oracle.com>
	<55E56A0B020000780009E76A@prv-mh.provo.novell.com>
	<20150901152349.GD11425@l.oracle.com>
	<55E5E644020000780009EB3F@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <konrad.wilk@oracle.com>) id 1ZWoq7-0006Tj-Bm
	for xen-devel@lists.xenproject.org; Tue, 01 Sep 2015 16:55:19 +0000
Content-Disposition: inline
In-Reply-To: <55E5E644020000780009EB3F@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: andrew.cooper3@citrix.com, wei.liu2@citrix.com, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Tue, Sep 01, 2015 at 09:54:12AM -0600, Jan Beulich wrote:
> >>> On 01.09.15 at 17:23, <konrad.wilk@oracle.com> wrote:
> > There is only need for the compat layer once I move the 'xen_tmem_oid_t' to
> > the tmem.h header file - and there is where the introduction in xlat.lst is 
> > done:
> > 
> > --- a/xen/include/xlat.lst
> > +++ b/xen/include/xlat.lst
> > @@ -103,6 +103,7 @@
> >  !      sched_poll                      sched.h
> >  ?      sched_remote_shutdown           sched.h
> >  ?      sched_shutdown                  sched.h
> > +?      xen_tmem_oid                    tmem.h
> 
> Looks like your problem is the xen_ prefix here - no other entity has
> it, despite there being a number of examples where the actual type
> uses such a prefix.

Yup! This made it work:


diff --git a/xen/common/compat/tmem_xen.c b/xen/common/compat/tmem_xen.c
index 6bd1ad4..db08005 100644
--- a/xen/common/compat/tmem_xen.c
+++ b/xen/common/compat/tmem_xen.c
@@ -11,9 +11,7 @@
 #include <xen/hypercall.h>
 #include <compat/tmem.h>
 
-#define xen_xen_tmem_oid xen_tmem_oid
-CHECK_xen_tmem_oid;
-#undef xen_xen_tmem_oid
+CHECK_tmem_oid;
 
 /*
  * Local variables:
diff --git a/xen/include/xlat.lst b/xen/include/xlat.lst
index ace1d53..3795059 100644
--- a/xen/include/xlat.lst
+++ b/xen/include/xlat.lst
@@ -103,7 +103,7 @@
 !	sched_poll			sched.h
 ?	sched_remote_shutdown		sched.h
 ?	sched_shutdown			sched.h
-?	xen_tmem_oid			tmem.h
+?	tmem_oid			tmem.h
 !	tmem_op				tmem.h
 ?	t_buf				trace.h
 ?	vcpu_get_physid			vcpu.h

Thank you!
> 
> Jan
>