From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH for 4.6 v2 3/3] xl/libxl: disallow saving a guest with vNUMA configured
Date: Wed, 9 Sep 2015 21:21:01 +0100 [thread overview]
Message-ID: <20150909202100.GA25704@zion.uk.xensource.com> (raw)
In-Reply-To: <55F07F2C.6050803@citrix.com>
On Wed, Sep 09, 2015 at 07:49:16PM +0100, Andrew Cooper wrote:
> On 09/09/15 18:03, Wei Liu wrote:
> >This is due to migration v2 frame record doesn't contain node
> >information.
>
> This isn't a migration v2 bug, and it was similarly non-functional with
> legacy migration. It was yet another oversight with the vNUMA work.
>
Indeed. I mentioned that in v1 patch but dropped it in v2 -- legacy
migration is gone anyway.
> Isn't this information available in the domain configuration for the domain
> sent in the xl header? (That layer violation also need removing).
>
Yes. But restoring a guest takes a path different from guest creation
to populate guest pages.
> Finally, your phrasing is somewhat unclear. I would recommend "The
> migration stream does not preserve node information" as a clearer
> alternative.
>
Fine by me.
Wei.
> ~Andrew
next prev parent reply other threads:[~2015-09-09 20:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 17:03 [PATCH for 4.6 v2 0/3] More vNUMA patches Wei Liu
2015-09-09 17:03 ` [PATCH for 4.6 v2 1/3] libxl: set ret to non-zero value in failure path Wei Liu
2015-09-10 10:55 ` Ian Campbell
2015-09-10 15:16 ` Ian Campbell
2015-09-11 13:26 ` Ian Jackson
2015-09-11 13:28 ` Wei Liu
2015-09-11 14:41 ` Ian Jackson
2015-09-09 17:03 ` [PATCH for 4.6 v2 2/3] libxc: introduce xc_domain_getvnuma Wei Liu
2015-09-10 11:01 ` Ian Campbell
2015-09-09 17:03 ` [PATCH for 4.6 v2 3/3] xl/libxl: disallow saving a guest with vNUMA configured Wei Liu
2015-09-09 17:17 ` Boris Ostrovsky
2015-09-09 17:29 ` Wei Liu
2015-09-09 17:33 ` Boris Ostrovsky
2015-09-09 17:41 ` Wei Liu
2015-09-10 13:53 ` Wei Liu
2015-09-09 18:49 ` Andrew Cooper
2015-09-09 20:21 ` Wei Liu [this message]
2015-09-10 11:04 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150909202100.GA25704@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).